BigW Consortium Gitlab

  1. 11 Dec, 2017 1 commit
    • Add cop for use of remove_column · 1ab33b15
      Sean McGivern authored
      remove_column should only be used in the up (or change) step of a migration if
      it's a post-deployment migration. Otherwise there will be downtime due to the
      ActiveRecord column cache, which we can avoid by using the IgnorableColumn
      concern in combination with a post-deployment migration.
  2. 17 Nov, 2017 1 commit
    • Prevent update_column_in_batches on large tables · d8be9814
      Sean McGivern authored
      add_column_with_default is implemented in terms of update_column_in_batches, but
      update_column_in_batches can be used independently. Neither of these should be
      used on the specified large tables, because they will cause issues on large
      instances like GitLab.com.
      
      This also ignores the cop for all existing migrations, renaming
      AddColumnWithDefaultToLargeTable where appropriate.
  3. 16 Nov, 2017 1 commit
  4. 21 Oct, 2017 1 commit
  5. 18 Oct, 2017 1 commit
  6. 10 Oct, 2017 1 commit
  7. 07 Oct, 2017 1 commit
    • Replaces `tag: true` into `:tag` in the specs · 0ce67858
      Jacopo authored
      Replaces all the explicit include metadata syntax in the specs (tag:
      true) into the implicit one (:tag).
      Added a cop to prevent future errors and handle autocorrection.
  8. 14 Aug, 2017 1 commit
  9. 01 Aug, 2017 1 commit
  10. 26 Jul, 2017 1 commit
  11. 14 Jul, 2017 1 commit
  12. 07 Jul, 2017 2 commits
    • Added EachBatch for iterating tables in batches · ff78af15
      Yorick Peterse authored
      This module provides a class method called `each_batch` that can be used
      to iterate tables in batches in a more efficient way compared to Rails'
      `in_batches` method. This commit also includes a RuboCop cop to
      blacklist the use of `in_batches` in favour of this new method.
    • Added EachBatch for iterating tables in batches · 5f9c8458
      Yorick Peterse authored
      This module provides a class method called `each_batch` that can be used
      to iterate tables in batches in a more efficient way compared to Rails'
      `in_batches` method. This commit also includes a RuboCop cop to
      blacklist the use of `in_batches` in favour of this new method.
  13. 06 Jul, 2017 3 commits
  14. 05 Jul, 2017 1 commit
  15. 14 Jun, 2017 2 commits
  16. 13 Jun, 2017 1 commit
  17. 07 Jun, 2017 1 commit
  18. 06 Jun, 2017 1 commit
  19. 31 May, 2017 1 commit
  20. 29 May, 2017 1 commit
  21. 28 Apr, 2017 3 commits
  22. 05 Apr, 2017 1 commit
  23. 07 Mar, 2017 1 commit
  24. 01 Mar, 2017 1 commit
    • Add RuboCop cop for custom error classes · 8dd097a9
      Sean McGivern authored
      From the Ruby style guide:
      
          # bad
          class FooError < StandardError
          end
      
          # okish
          class FooError < StandardError; end
      
          # good
          FooError = Class.new(StandardError)
      
      This cop does that, but only for error classes (classes where the
      superclass ends in 'Error'). We have empty controllers and models, which
      are perfectly valid empty classes.
  25. 23 Feb, 2017 5 commits
  26. 10 Feb, 2017 1 commit
    • Enforce use of add_concurrent_foreign_key · 766060bc
      Yorick Peterse authored
      This adds a Rubocop rule to enforce the use of
      add_concurrent_foreign_key instead of the regular add_foreign_key
      method. This cop has been disabled for existing migrations so we don't
      need to change those.
  27. 09 Feb, 2017 1 commit
  28. 08 Feb, 2017 2 commits
  29. 31 Jan, 2017 1 commit