- 11 Dec, 2017 1 commit
-
-
Sean McGivern authored
remove_column should only be used in the up (or change) step of a migration if it's a post-deployment migration. Otherwise there will be downtime due to the ActiveRecord column cache, which we can avoid by using the IgnorableColumn concern in combination with a post-deployment migration.
-
- 17 Nov, 2017 1 commit
-
-
Sean McGivern authored
add_column_with_default is implemented in terms of update_column_in_batches, but update_column_in_batches can be used independently. Neither of these should be used on the specified large tables, because they will cause issues on large instances like GitLab.com. This also ignores the cop for all existing migrations, renaming AddColumnWithDefaultToLargeTable where appropriate.
-
- 16 Nov, 2017 1 commit
-
-
Jacopo authored
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
-
- 21 Oct, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 18 Oct, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 10 Oct, 2017 1 commit
-
-
Sean McGivern authored
The types `timestamp` and `datetime` are aliases: https://github.com/rails/rails/blob/v4.2.10/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb#L362-L364
-
- 07 Oct, 2017 1 commit
-
-
Jacopo authored
Replaces all the explicit include metadata syntax in the specs (tag: true) into the implicit one (:tag). Added a cop to prevent future errors and handle autocorrection.
-
- 14 Aug, 2017 1 commit
-
-
Michael Kozono authored
-
- 01 Aug, 2017 1 commit
-
-
Shinya Maeda authored
-
- 26 Jul, 2017 1 commit
-
-
Robert Speicher authored
- ci_builds -- 33 million rows, 55 GB - merge_request_diff_files -- 5 million rows, 9 GB (and growing rapidly) - merge_request_diffs -- 5 million rows, 190 GB
-
- 14 Jul, 2017 1 commit
-
-
Yorick Peterse authored
These indexes are not recorded in the WAL (at least until PostgreSQL 10) and this isn't worth the minor performance improvement over btree indexes.
-
- 07 Jul, 2017 2 commits
-
-
Yorick Peterse authored
This module provides a class method called `each_batch` that can be used to iterate tables in batches in a more efficient way compared to Rails' `in_batches` method. This commit also includes a RuboCop cop to blacklist the use of `in_batches` in favour of this new method.
-
Yorick Peterse authored
This module provides a class method called `each_batch` that can be used to iterate tables in batches in a more efficient way compared to Rails' `in_batches` method. This commit also includes a RuboCop cop to blacklist the use of `in_batches` in favour of this new method.
-
- 06 Jul, 2017 3 commits
-
-
Douwe Maan authored
-
Yorick Peterse authored
This cop has been renamed to ActiveRecordSerialize to match the way "ActiveRecord" is usually written.
-
Yorick Peterse authored
This is allowed for existing instances so we don't end up 76 offenses right away, but for new code one should _only_ use this if they _have_ to remove non database data. Even then it's usually better to do this in a service class as this gives you more control over how to remove the data (e.g. in bulk).
-
- 05 Jul, 2017 1 commit
-
-
Douwe Maan authored
-
- 14 Jun, 2017 2 commits
-
-
Robert Speicher authored
Resolves the `codeclimate` CI failure
-
Robert Speicher authored
This cop adds an offense when `before`, `after`, or `around` are used as single-line blocks.
-
- 13 Jun, 2017 1 commit
-
-
blackst0ne authored
-
- 07 Jun, 2017 1 commit
-
-
Yorick Peterse authored
One should really use a separate table instead of using polymorphic associations. See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/11168 for more information.
-
- 06 Jun, 2017 1 commit
-
-
blackst0ne authored
Add a rubocop rule to check if a method 'redirect_to' is used without explicitly set 'status' in 'destroy' actions of controllers
-
- 31 May, 2017 1 commit
-
-
Yorick Peterse authored
This Cop blacklists the use of ActiveRecord's "serialize" method, except for cases where we already use this.
-
- 29 May, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 28 Apr, 2017 3 commits
-
-
Robert Speicher authored
-
Robert Speicher authored
We're going to add another cop that deals with another aspect of `add_column_with_default`, so we need to separate them.
-
Robert Speicher authored
-
- 05 Apr, 2017 1 commit
-
-
blackst0ne authored
-
- 07 Mar, 2017 1 commit
-
-
Douwe Maan authored
-
- 01 Mar, 2017 1 commit
-
-
Sean McGivern authored
From the Ruby style guide: # bad class FooError < StandardError end # okish class FooError < StandardError; end # good FooError = Class.new(StandardError) This cop does that, but only for error classes (classes where the superclass ends in 'Error'). We have empty controllers and models, which are perfectly valid empty classes.
-
- 23 Feb, 2017 5 commits
-
-
Douwe Maan authored
This reverts commit e00fb2bdc2090e9cabeb1eb35a2672a882cc96e9. # Conflicts: # .rubocop.yml # .rubocop_todo.yml # lib/gitlab/ci/config/entry/global.rb # lib/gitlab/ci/config/entry/jobs.rb # spec/lib/gitlab/ci/config/entry/factory_spec.rb # spec/lib/gitlab/ci/config/entry/global_spec.rb # spec/lib/gitlab/ci/config/entry/job_spec.rb # spec/lib/gitlab/ci/status/build/factory_spec.rb # spec/lib/gitlab/incoming_email_spec.rb
-
Douwe Maan authored
This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
-
Douwe Maan authored
-
Douwe Maan authored
-
Douwe Maan authored
-
- 10 Feb, 2017 1 commit
-
-
Yorick Peterse authored
This adds a Rubocop rule to enforce the use of add_concurrent_foreign_key instead of the regular add_foreign_key method. This cop has been disabled for existing migrations so we don't need to change those.
-
- 09 Feb, 2017 1 commit
-
-
Robert Speicher authored
-
- 08 Feb, 2017 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- 31 Jan, 2017 1 commit
-
-
Adam Pahlevi authored
code fix for aesthetic & conventions remove unused proc
-