- 29 May, 2017 1 commit
-
-
Douwe Maan authored
-
- 24 May, 2017 1 commit
-
-
Douwe Maan authored
-
- 23 May, 2017 1 commit
-
-
Douwe Maan authored
-
- 19 May, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 17 May, 2017 1 commit
-
-
Yorick Peterse authored
This commit introduces the usage of Common Table Expressions (CTEs) to efficiently retrieve nested group hierarchies, without having to rely on the "routes" table (which is an _incredibly_ inefficient way of getting the data). This requires a patch to ActiveRecord (found in the added initializer) to work properly as ActiveRecord doesn't support WITH statements properly out of the box. Unfortunately MySQL provides no efficient way of getting nested groups. For example, the old routes setup could easily take 5-10 seconds depending on the amount of "routes" in a database. Providing vastly different logic for both MySQL and PostgreSQL will negatively impact the development process. Because of this the various nested groups related methods return empty relations when used in combination with MySQL. For project authorizations the logic is split up into two classes: * Gitlab::ProjectAuthorizations::WithNestedGroups * Gitlab::ProjectAuthorizations::WithoutNestedGroups Both classes get the fresh project authorizations (= as they should be in the "project_authorizations" table), including nested groups if PostgreSQL is used. The logic of these two classes is quite different apart from their public interface. This complicates development a bit, but unfortunately there is no way around this. This commit also introduces Gitlab::GroupHierarchy. This class can be used to get the ancestors and descendants of a base relation, or both by using a UNION. This in turn is used by methods such as: * Namespace#ancestors * Namespace#descendants * User#all_expanded_groups Again this class relies on CTEs and thus only works on PostgreSQL. The Namespace methods will return an empty relation when MySQL is used, while User#all_expanded_groups will return only the groups a user is a direct member of. Performance wise the impact is quite large. For example, on GitLab.com Namespace#descendants used to take around 580 ms to retrieve data for a particular user. Using CTEs we are able to reduce this down to roughly 1 millisecond, returning the exact same data. == On The Fly Refreshing Refreshing of authorizations on the fly (= when users.authorized_projects_populated was not set) is removed with this commit. This simplifies the code, and ensures any queries used for authorizations are not mutated because they are executed in a Rails scope (e.g. Project.visible_to_user). This commit includes a migration to schedule refreshing authorizations for all users, ensuring all of them have their authorizations in place. Said migration schedules users in batches of 5000, with 5 minutes between every batch to smear the load around a bit. == Spec Changes This commit also introduces some changes to various specs. For example, some specs for ProjectTeam assumed that creating a personal project would _not_ lead to the owner having access, which is incorrect. Because we also no longer refresh authorizations on the fly for new users some code had to be added to the "empty_project" factory. This chunk of code ensures that the owner's permissions are refreshed after creating the project, something that is normally done in Projects::CreateService.
-
- 12 May, 2017 1 commit
-
-
Phil Hughes authored
-
- 11 May, 2017 1 commit
-
-
Jarka Kadlecova authored
-
- 10 May, 2017 2 commits
-
-
Phil Hughes authored
Closes #31541
-
blackst0ne authored
-
- 09 May, 2017 3 commits
-
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
Toon Claes authored
In commit 020295ff a regex was added to quickly determine if mentionables might be referenced. But this didn't take into account the note might not belong to a project. So when it doesn't belong to a project, assume the default issue tracker is used, and use DEFAULT_PATTERN to check if there are mentionables. Fixes gitlab-org/gitlab-ce#31993
-
- 06 May, 2017 1 commit
-
-
Sean McGivern authored
-
- 05 May, 2017 2 commits
-
-
Michael Kozono authored
-
Valery Sizov authored
-
- 04 May, 2017 3 commits
-
-
James Edwards-Jones authored
-
Valery Sizov authored
-
blackst0ne authored
-
- 03 May, 2017 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- 02 May, 2017 1 commit
-
-
Bob Van Landuyt authored
If the cached html_field for a markdown_field is `nil` while the mfarkdown_field is not, it needs to be refreshed.
-
- 25 Apr, 2017 1 commit
-
-
Nick Thomas authored
Swap a before_save call with a before_create/before_update pair to avoid a confict with elasticsearch-model
-
- 24 Apr, 2017 1 commit
-
-
Stan Hu authored
We see in #27387 that a call to `polymorphic_path` will cause duplicate SELECT route calls for each merge request in a milestone. This happens because calling `project.namespace.becomes(Namespace)` will instantiate a new instance of a Namespace for each merge request, which causes a N+1 query on the routes table. This change caches the state of the route by the specific class and ID, which dramatically eliminates duplicate work.
-
- 21 Apr, 2017 2 commits
-
-
Nick Thomas authored
-
Nick Thomas authored
-
- 19 Apr, 2017 1 commit
-
-
Adam Niedzielski authored
Closes #30964
-
- 12 Apr, 2017 1 commit
-
-
Robert Speicher authored
-
- 08 Apr, 2017 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- 07 Apr, 2017 2 commits
-
-
Kamil Trzcinski authored
-
James Edwards-Jones authored
-
- 06 Apr, 2017 6 commits
-
-
Douwe Maan authored
-
Timothy Andrew authored
... when the user is destroyed. 1. Normally, for a given awardable and award emoji name, a user is only allowed to create a single award emoji. 2. This validation needs to be removed for ghost users, since: - User A and User B have created award emoji - with the same name and against the same awardable - User A is deleted. Their award emoji is moved to the ghost user - User B is deleted. Their award emoji needs to be moved to the ghost user. However, this breaks the uniqueness validation, since the ghost user is only allowed to have one award emoji of a given name for a given awardable
-
James Edwards-Jones authored
Added changelog
-
Alexis Reigel authored
-
Alexis Reigel authored
-
Alexis Reigel authored
-
- 05 Apr, 2017 3 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
Douwe Maan authored
-