BigW Consortium Gitlab

  1. 31 Aug, 2017 1 commit
    • `current_application_settings` belongs on `Gitlab::CurrentSettings` · 5883ce95
      Sean McGivern authored
      The initializers including this were doing so at the top level, so every object
      loaded after them had a `current_application_settings` method. However, if
      someone had rack-attack enabled (which was loaded before these initializers), it
      would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
      have that method.
      
      To fix this:
      
      1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
         `Object.new.current_application_settings` to work.
      2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
         like that in several places.
      3. Change the initializers to use that new form.
  2. 21 Jun, 2017 1 commit
  3. 23 Feb, 2017 2 commits
  4. 18 Oct, 2016 1 commit
  5. 03 Aug, 2016 1 commit
  6. 24 Feb, 2016 1 commit
    • Move "I should see Crowd login form" feature to a view spec · b95ef77e
      Robert Speicher authored
      We were doing all kinds of code gymnastics to "enable" Crowd in the
      feature spec and this would sometimes cause a transient failure.
      
      Really what it's testing is if the Crowd login form shows when Crowd's
      enabled, so this is much better suited to a view spec.