- 23 Aug, 2017 1 commit
-
-
Jacob Vosmaer authored
-
- 11 Aug, 2017 1 commit
-
-
Lin Jen-Shin authored
-
- 21 Jun, 2017 1 commit
-
-
Zeger-Jan van de Weg authored
-
- 06 Jun, 2017 2 commits
-
-
Douglas Barbosa Alexandre authored
-
Pawel Chojnacki authored
-
- 02 Jun, 2017 5 commits
-
-
Pawel Chojnacki authored
small code formatting changes
-
Pawel Chojnacki authored
+ use strip_heredoc to make the text in tests much more readable
-
Pawel Chojnacki authored
-
Douwe Maan authored
-
Lin Jen-Shin authored
-
- 01 Jun, 2017 2 commits
-
-
Lin Jen-Shin authored
it a bit more robust against missing options, which we did guard on for some cases.
-
- 31 May, 2017 1 commit
-
-
Kamil Trzcinski authored
-
- 04 May, 2017 3 commits
-
-
Ruben Davila authored
-
Valery Sizov authored
-
Ruben Davila authored
-
- 10 Apr, 2017 1 commit
-
-
Robert Speicher authored
This seed downloads 2.1 GB worth of repositories. Google can afford the bandwidth, but if a person using the GDK is on a metered connection, that's not so great. Also the GDK test suite runs this seed, so every CI run for that project had to download those as well. Needlessly wasteful.
-
- 06 Apr, 2017 1 commit
-
-
Kamil Trzciński authored
-
- 05 Apr, 2017 1 commit
-
-
Kamil Trzciński authored
-
- 04 Apr, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 03 Apr, 2017 3 commits
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 30 Mar, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 20 Mar, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 06 Mar, 2017 1 commit
-
-
Eric Eastwood authored
-
- 03 Mar, 2017 1 commit
-
-
Robert Speicher authored
-
- 27 Feb, 2017 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 24 Feb, 2017 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- 15 Feb, 2017 1 commit
-
-
Eric Eastwood authored
``` rake db:seed_fu FILTER=abuse_reports ``` Thanks to @stanhu, https://gitlab.com/gitlab-org/gitlab-ce/issues/28059#note_23325328
-
- 03 Feb, 2017 1 commit
-
-
Adam Pahlevi authored
add complete changelog for !8949
-
- 25 Jan, 2017 1 commit
-
-
Yorick Peterse authored
There were two cases that could be problematic: 1. Because sometimes AuthorizedProjectsWorker would be scheduled in a transaction it was possible for a job to run/complete before a COMMIT; resulting in it either producing an error, or producing no new data. 2. When scheduling jobs the code would not wait until completion. This could lead to a user creating a project and then immediately trying to push to it. Usually this will work fine, but given enough load it might take a few seconds before a user has access. The first one is problematic, the second one is mostly just annoying (but annoying enough to warrant a solution). This commit changes two things to deal with this: 1. Sidekiq scheduling now takes places after a COMMIT, this is ensured by scheduling using Rails' after_commit hook instead of doing so in an arbitrary method. 2. When scheduling jobs the calling thread now waits for all jobs to complete. Solution 2 requires tracking of job completions. Sidekiq provides a way to find a job by its ID, but this involves scanning over the entire queue; something that is very in-efficient for large queues. As such a more efficient solution is necessary. There are two main Gems that can do this in a more efficient manner: * sidekiq-status * sidekiq_status No, this is not a joke. Both Gems do a similar thing (but slightly different), and the only difference in their name is a dash vs an underscore. Both Gems however provide far more than just checking if a job has been completed, and both have their problems. sidekiq-status does not appear to be actively maintained, with the last release being in 2015. It also has some issues during testing as API calls are not stubbed in any way. sidekiq_status on the other hand does not appear to be very popular, and introduces a similar amount of code. Because of this I opted to write a simple home grown solution. After all, all we need is storing a job ID somewhere so we can efficiently look it up; we don't need extra web UIs (as provided by sidekiq-status) or complex APIs to update progress, etc. This is where Gitlab::SidekiqStatus comes in handy. This namespace contains some code used for tracking, removing, and looking up job IDs; all without having to scan over an entire queue. Data is removed explicitly, but also expires automatically just in case. Using this API we can now schedule jobs in a fork-join like manner: we schedule the jobs in Sidekiq, process them in parallel, then wait for completion. By using Sidekiq we can leverage all the benefits such as being able to scale across multiple cores and hosts, retrying failed jobs, etc. The one downside is that we need to make sure we can deal with unexpected increases in job processing timings. To deal with this the class Gitlab::JobWaiter (used for waiting for jobs to complete) will only wait a number of seconds (30 by default). Once this timeout is reached it will simply return. For GitLab.com almost all AuthorizedProjectWorker jobs complete in seconds, only very rarely do we spike to job timings of around a minute. These in turn seem to be the result of external factors (e.g. deploys), in which case a user is most likely not able to use the system anyway. In short, this new solution should ensure that jobs are processed properly and that in almost all cases a user has access to their resources whenever they need to have access.
-
- 15 Dec, 2016 1 commit
-
-
twonegatives authored
-
- 02 Dec, 2016 1 commit
-
-
DJ Mountney authored
This is useful for when runner is bundled with gitlab, like in a kubernetes stack, and we want the runner to be able to register with gitlab as soon as they both come up.
-
- 28 Nov, 2016 1 commit
-
-
Kamil Trzcinski authored
-
- 25 Nov, 2016 1 commit
-
-
Yorick Peterse authored
When I proposed using serializable transactions I was hoping we would be able to refresh data of individual users concurrently. Unfortunately upon closer inspection it was revealed this was not the case. This could result in a lot of queries failing due to serialization errors, overloading the database in the process (given enough workers trying to update the target table). To work around this we're now using a Redis lease that is cancelled upon completion. This ensures we can update the data of different users concurrently without overloading the database. The code will try to obtain the lease until it succeeds, waiting at least 1 second between retries. This is necessary as we may otherwise end up _not_ updating the data which is not an option.
-
- 23 Nov, 2016 1 commit
-
-
Ahmad Sherif authored
-
- 18 Nov, 2016 2 commits
-
-
Ahmad Sherif authored
Closes #23150
-
James Lopez authored
-