BigW Consortium Gitlab

  1. 05 Jul, 2016 1 commit
    • Improve the error message displayed when branch creation fails. · eb16e1e3
      Timothy Andrew authored
      Note: This feature was developed independently on master while this was
      in review. I've removed the conflicting bits and left the relevant
      additions, mainly a test for `Gitlab::Git::Hook`. The original commit
      message follows:
      
      1. `gitlab-shell` outputs errors to `stderr`, but we weren't using this
         information, prior to this commit. Now we capture the `stderr`, and
         display it in the flash message when branch creation fails.
      
      2. This can be used to display better errors for other git operation
         failures with small tweaks.
      
      3. The return value of `Gitlab::Git::Hook#trigger` is changed from a
         simple `true`/`false` to a tuple of `[status, errors]`. All usages
         and tests have been updated to reflect this change.
      
      4. This is only relevant to branch creation _from the Web UI_, since SSH
         and HTTP pushes access `gitlab-shell` either directly or through
         `gitlab-workhorse`.
      
      5. A few minor changes need to be made on the `gitlab-shell` end. Right
         now, the `stderr` message it outputs is prefixed by "GitLab: ", which
         shows up in our flash message. This is better removed.
  2. 30 Jun, 2016 2 commits
  3. 27 Jun, 2016 4 commits
  4. 16 Jun, 2016 2 commits
  5. 12 Jun, 2016 1 commit
    • Fix Error 500 when viewing a blob with binary characters after the 1024-byte mark · 0fdfd2dd
      Stan Hu authored
      Here was the problem:
      
      1. When determining whether a given blob is viewable text, gitlab_git reads the first 1024 bytes and checks with Linguist whether it is a text or binary file.
      2. If the blob is text, GitLab will attempt to display it.
      3. However, if the text has binary characters after the first 1024 bytes, then GitLab will attempt to load the entire contents, but the encoding will be ASCII-8BIT since there are binary characters.
      4. The Error 500 results when GitLab attempts to display a mix UTF-8 and ASCII-8BIT.
      
      To fix this, we load as much data as we are willing to display so that the detection will work properly. Requires
      an update to gitlab_git: gitlab-org/gitlab_git!86
      
      Closes #13826
  6. 04 Apr, 2016 1 commit
  7. 29 Jan, 2016 1 commit
    • Prevent transient Capybara timeouts during feature tests · bbe0fa91
      Robert Speicher authored
      The problem occurred because asset compilation takes a long time, so
      when the asset cache didn't exist and the first test ran, it would often
      (randomly) time out during the generation before the actual test even
      had a chance to run.
      
      Now we check if the cache exists before the suite runs, and if not, we
      manually fire a request to the root URL in order to generate it. This
      should allow subsequent tests to use the cached assets.
  8. 08 Dec, 2015 1 commit
  9. 07 Dec, 2015 1 commit
  10. 04 Dec, 2015 1 commit
  11. 03 Nov, 2015 1 commit
  12. 13 Oct, 2015 1 commit
  13. 14 Aug, 2015 3 commits
  14. 26 Jul, 2015 1 commit
  15. 24 Jul, 2015 1 commit
  16. 21 Jul, 2015 1 commit
  17. 22 Jun, 2015 1 commit
  18. 02 May, 2015 1 commit
  19. 28 Apr, 2015 1 commit
  20. 28 Mar, 2015 1 commit
  21. 17 Feb, 2015 1 commit
    • TestEnv improvements · 71948108
      Robert Speicher authored
      - Simplify cleaning the temporary testing path in TestEnv
      - Don't run gitlab:shell:install if it's already installed
      - Run git commands quietly
  22. 12 Feb, 2015 1 commit
  23. 11 Jan, 2015 2 commits
  24. 10 Jan, 2015 1 commit
  25. 18 Nov, 2014 2 commits
  26. 01 Oct, 2014 1 commit
  27. 27 Sep, 2014 1 commit
  28. 22 Sep, 2014 1 commit
  29. 31 Jul, 2014 3 commits