Pick 10.2.4 security fixes into master

See merge request gitlab-org/gitlab-ce!15821

(cherry picked from commit 1eff1bd3)

d332c8c7 Merge branch '36679-non-authorized-user-may-see-wikis-or-pipeline-page' into 'security-10-2'
8c0aa7d4 Merge branch 'bvl-10-2-email-disclosure' into 'security-10-2'
8f29d264 Merge branch 'rs-security-group-api' into 'security-10-2'
c59ae547 Merge branch 'issue_30663' into 'security-10-2'
f4fbe61a Merge branch 'note-preview' into 'security-10-2'
0f811675 Manually add 10.2.4 changelog entries
f71e48a0 Resolve conflicts in app/models/user.rb

Keep track of the circuit breaker access check timings

Closes #39698

See merge request gitlab-org/gitlab-ce!15612

(cherry picked from commit 13ac8e57)

d4d06bde Keep track of storage check timings

Do not raise when downstream pipeline is created

Closes #40987

See merge request gitlab-org/gitlab-ce!15837

(cherry picked from commit 95daf62b)

90569a17 Do not raise when downstream pipeline is created

Add recaptcha_check_if_spammable for issualbes than arent spammables

See merge request gitlab-org/gitlab-ce!15817

(cherry picked from commit 689bc9ea)

0e935c76 Add recaptcha_check_if_spammable for issualbes than arent spammables

Fix invalid pipeline build chain tag evaluation

Closes #40944

See merge request gitlab-org/gitlab-ce!15805

(cherry picked from commit 103269b9)

b30e0e06 Fix invalid pipeline build chain tag evaluation
ad3be46b Implement and use Gitlab::Ci::Pipeline::Chain::Command
865341ac Fix a bug of before_sha being inproperly evaluated to `checkout_sha`
b5f6a5f9 Add Chain::Command specs
99101f94 Fix Rubocop

Fix gitlab:import:repos Rake task moving repositories into the wrong location

Closes #40765

See merge request gitlab-org/gitlab-ce!15823

(cherry picked from commit 7694ae88)

78f7c3c8 Fix gitlab:import:repos Rake task moving repositories into the wrong location
e8cced80 Fix failing importer test case on MySQL due to missing trailing slash in root path
917a112e Simplify normalizing of paths
86661a3a Use build instead of create in importer spec
f1eaab7b Remove the need for destroy and add a comment in the spec

Resolve "Deploy markers should be more verbose"

Closes #38032

See merge request gitlab-org/gitlab-ce!15641

(cherry picked from commit 87300546)

d377aa54 Changed the deploy markers on the prometheus dashboard to be more verbose
3642f6f0 Reduce the size of the deploy flag when there's no tag available

Allow git pull/push on project redirects

Closes #35385

See merge request gitlab-org/gitlab-ce!15670

(cherry picked from commit 2a181d68)

37c99562 Allow git pull/push on project redirects
64811239 Allow group/username transfers:
4344bba4 Fixes wrong condition on git access
b6bac528 Wrap ProjectMoved behavior into a class
70676e3b Fixes permanent migration
3328950e Moves allowed_path_validation up to Namespace
54900c4a Addreses ME review comments
740ed1e0 Add several improvements
6a0d9261 Add fixes based on MR suggestions
8a1a257b Ensures validations are only executed if RedirectRoute#permanent column exists
448f1c54 Fixes broken specs and suggestions on MR
da789af6 Add fixes based on MR comments
2bd96f5f Bump GITLAB_SHELL_VERSION to 5.10.2
75981dc4 Ensure RedirectRoute column information is flushed

Fix N+1 query when displaying events

See merge request gitlab-org/gitlab-ce!15788

(cherry picked from commit 53026c42)

c52a36e8 Fix N+1 query when displaying events

Merge branch '29483-no-feedback-when-checking-on-checklist-if-potential-spam-was-detected' into 'master'

Resolve "No feedback when checking on checklist if potential spam was detected"

Closes #29483

See merge request gitlab-org/gitlab-ce!15408

(cherry picked from commit d32032de)

efc86c26 Mock spam?
8e9a9030 Merge remote-tracking branch 'origin/master' into…
019db0fd TEMP mock askismet spam check
11e51be6 respond_to json with json version of verify view in recaptcha_check_with_fallback
18955cdc Differentiate between spam related error and other update errors
9dcf093c Start recaptcha modal and render partial instead
64b13133 Append and remove api script when reCAPTCHA is needed
c9a67fab put-over-post the recaptcha form
cb22ae66 remove comments
20517d64 remove comments
e174d02e Review changes
7a7d4a2a Add spec
8f617b45 Added changelog
db3f1a47 Review changes
4d0c78de Add to tasklist
36ea921b Remove duplicate TaskList
6bffe620 Add app_spec for spam
d95350bc Finished specs
cf951cba FOR REVIEWERS
6c50e850 FOR MERGE
25931f73 Allow script src to be mockable
c3463e00 Merge remote-tracking branch 'origin/master' into…
2c170b8d fix eslint
a318c757 Fix redirect
8a02fbd0 BE review changes
dda03f4d Fix spec
910c7205 Fix spec
fafbd7e5 remove duplicate destroy

This reverts commit 102b3232, reversing
changes made to d87d1e79.

Check NFS mounts in a separate process

Closes #39847

See merge request gitlab-org/gitlab-ce!15426

Moving the check out of the general requests, makes sure we don't have
any slowdown in the regular requests.

To keep the process performing this checks small, the check is still
performed inside a unicorn. But that is called from a process running
on the same server.

Because the checks are now done outside normal request, we can have a
simpler failure strategy:

The check is now performed in the background every
`circuitbreaker_check_interval`. Failures are logged in redis. The
failures are reset when the check succeeds. Per check we will try
`circuitbreaker_access_retries` times within
`circuitbreaker_storage_timeout` seconds.

When the number of failures exceeds
`circuitbreaker_failure_count_threshold`, we will block access to the
storage.

After `failure_reset_time` of no checks, we will clear the stored
failures. This could happen when the process that performs the checks
is not running.

Fix new personal access token showing up in a flash message

Closes #40754

See merge request gitlab-org/gitlab-ce!15707

Clean test path between merge request handler tests

Closes #40900

See merge request gitlab-org/gitlab-ce!15792

Migrate Git::Repository#fsck to Gitaly

Closes gitaly#795

See merge request gitlab-org/gitlab-ce!15731

Use relative _path helper URLs in the GitLab UI

Closes #40825

See merge request gitlab-org/gitlab-ce!15738

Replace absolute URLs on related branches/MRs with relative url to avoid hostname

Closes #40555

See merge request gitlab-org/gitlab-ce!15735

Fix loading branches list on cherry pick modal after merge.

Closes #33894

See merge request gitlab-org/gitlab-ce!15306

Add documentation about using US-English

Closes #40675

See merge request gitlab-org/gitlab-ce!15656

Fix transient error in pikadayToString

Closes #40858

See merge request gitlab-org/gitlab-ce!15754

fix #39233 - 500 in merge request

Closes #39233

See merge request gitlab-org/gitlab-ce!15774

Dependency validator

Closes #34834

See merge request gitlab-org/gitlab-ce!14009

create_merge_request_handler_spec needs a repository for some tests but
this repository lasts on disk by default which causes failures of other
tests. TestEnv.clean_test_path is used to get rid of the repository
after each test.

Closes #40900

- handle unchanged empty lines in inline diff

Fixed remove deploy key loading icon not being removed after canceling

Closes #37595

See merge request gitlab-org/gitlab-ce!15779

Resolve "updateEndpoint undefined on Issue page"

Closes #40715

See merge request gitlab-org/gitlab-ce!15698

Use Gitaly 0.59.0

See merge request gitlab-org/gitlab-ce!15795

Docs: fix typo

See merge request gitlab-org/gitlab-ce!15798

Update prometheus-client-mmap gem to highly optimized version

See merge request gitlab-org/gitlab-ce!15796

[CE] Fix message when pushing to Geo secondary

See merge request gitlab-org/gitlab-ce!15793

Fixed merge request locked icon size

Closes #40876

See merge request gitlab-org/gitlab-ce!15767

Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/40825