- 15 Dec, 2016 1 commit
-
-
Jacob Vosmaer authored
-
- 14 Dec, 2016 1 commit
-
-
Rémy Coutable authored
This was because the MR was a bit behind master and the error message got updated in the meantime by 79aad815. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 13 Dec, 2016 5 commits
-
-
Robert Schilling authored
-
Robert Schilling authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Robert Schilling authored
-
Robert Schilling authored
-
- 12 Dec, 2016 2 commits
-
-
Rémy Coutable authored
The issue was arising when `#current_user` was called a second time after a user was impersonated: the `User#is_admin?` check would be performed on it and it would fail. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Robert Schilling authored
-
- 09 Dec, 2016 1 commit
-
-
Robert Schilling authored
-
- 08 Dec, 2016 1 commit
-
-
Felipe Artur authored
-
- 07 Dec, 2016 3 commits
-
-
tiagonbotelho authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Robert Schilling authored
-
- 06 Dec, 2016 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 05 Dec, 2016 1 commit
-
-
Bob Van Landuyt authored
When a merge request can only be merged when all discussions are resolved. This feature allows to easily delegate those discussions to a new issue, while marking them as resolved in the merge request. The user is presented with a new issue, prepared with mentions of all unresolved discussions, including the first unresolved note of the discussion, time and link to the note. When the issue is created, the discussions in the merge request will get a system note directing the user to the newly created issue.
-
- 04 Dec, 2016 3 commits
-
-
Z.J. van de Weg authored
-
Robert Schilling authored
-
Z.J. van de Weg authored
Fixes #18448
-
- 01 Dec, 2016 5 commits
-
-
Guyzmo authored
Adding the necessary API for the new /snippets Restful resource added with this commit. Added a new Grape class `Snippets`, as well as a `PersonalSnippet` entity. Issue: #20042 Merge-Request: !6373 Signed-off-by: Guyzmo <guyzmo+gitlab+pub@m0g.net>
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Yorick Peterse authored
By passing commit data to this worker we remove the need for querying the Git repository for every job. This in turn reduces the time spent processing each job. The migration included migrates jobs from the old format to the new format. For this to work properly it requires downtime as otherwise workers may start producing errors until they're using a newer version of the worker code.
-
Robert Schilling authored
-
Robert Speicher authored
-
- 30 Nov, 2016 2 commits
-
-
Grzegorz Bizon authored
-
Robert Schilling authored
-
- 29 Nov, 2016 4 commits
-
-
Rémy Coutable authored
Sorting by created_at can lead to uncertainties if two records are created at the same time. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Grzegorz Bizon authored
-
Douwe Maan authored
Replace issue access checks with use of IssuableFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ## Which fixes are in this MR?
- Potentially untested - No test coverage - Test coverage of some sort exists (a test failed when error raised) - Test coverage of return value (a test failed when nil used) - Permissions check tested ### Issue lookup with access check Using `visible_to_user` likely makes these security issues too. See [Code smells](#code-smells). - [x] app/finders/notes_finder.rb:15 [`visible_to_user`] - [x] app/views/layouts/nav/_project.html.haml:73 [`visible_to_user`] [`.count`] - [x] app/services/merge_requests/build_service.rb:84 [`issue.try(:confidential?)`] - [x] lib/api/issues.rb:112 [`visible_to_user`] - CHANGELOG: Prevented API returning issues set to 'Only team members' to everyone - [x] lib/api/helpers.rb:126 [`can?(current_user, :read_issue, issue)`] Maybe here too? - [x] lib/gitlab/search_results.rb:53 [`visible_to_user`] ### Previous discussions - [ ] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b2ff264eddf9819d7693c14ae213d941494fe2b3_128_126 - [ ] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#7b6375270d22f880bdcb085e47b519b426a5c6c7_87_87 See merge request !2031 -
Douwe Maan authored
Fix label creation non members Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/23416 See merge request !2006
-
- 28 Nov, 2016 2 commits
-
-
Robert Schilling authored
-
Livier authored
Restore changes for api spec files Fix error in rspec Users Delete extra space Repositories-spec
-
- 25 Nov, 2016 2 commits
-
-
Z.J. van de Weg authored
The coverage wasn't exposed yet, now it is but only for detailed requests to save queries on the database.
-
Z.J. van de Weg authored
One of many requested in: gitlab-org/gitlab-ce#24768
-
- 24 Nov, 2016 1 commit
-
-
Douwe Maan authored
-
- 23 Nov, 2016 2 commits
-
-
Robert Schilling authored
-
Valery Sizov authored
-
- 22 Nov, 2016 1 commit
-
-
Robert Schilling authored
-
- 21 Nov, 2016 2 commits
-
-
Tomasz Maczukin authored
-
Robert Schilling authored
-