- 01 Jun, 2016 1 commit
-
-
Yorick Peterse authored
There are several changes to this module: 1. The use of an explicit stack in Participable#participants 2. Proc behaviour has been changed 3. Batch permissions checking == Explicit Stack Participable#participants no longer uses recursion to process "self" and all child objects, instead it uses an Array and processes objects in breadth-first order. This allows us to for example create a single Gitlab::ReferenceExtractor instance and pass this to any Procs. Re-using a ReferenceExtractor removes the need for running potentially many SQL queries every time a Proc is called on a new object. == Proc Behaviour Changed Previously a Proc in Participable was expected to return an Array of User instances. This has been changed and instead it's now expected that a Proc modifies the Gitlab::ReferenceExtractor passed to it. The return value of the Proc is ignored. == Permissions Checking The method Participable#participants uses Ability.users_that_can_read_project to check if the returned users have access to the project of "self" _without_ running multiple SQL queries for every user.
-
- 16 May, 2016 1 commit
-
-
Robert Speicher authored
Given an activity feed entry like: > Douwe Maan commented on [issue #123] at [gitlab-org/gitlab-ce] ...the `issue #123` link will now have a `title` attribute.
-
- 13 May, 2016 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- 09 May, 2016 1 commit
-
-
Jeroen van Baarsen authored
In 8278b763 the default behaviour of annotation has changes, which was causing a lot of noise in diffs. We decided in #17382 that it is better to get rid of the whole annotate gem, and instead let people look at schema.rb for the columns in a table. Fixes: #17382
-
- 06 May, 2016 1 commit
-
-
Zeger-Jan van de Weg authored
-
- 19 Apr, 2016 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 31 Mar, 2016 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 11 Mar, 2016 4 commits
-
-
Robert Speicher authored
-
Robert Speicher authored
It's unclear how these blank values got added, but GitLab.com had a few: ``` irb(main):002:0> Note.where("line_code IS NOT NULL AND line_code = ''").count => 439 ``` We've added a migration to convert any existing records to use a NULL value when blank, and updated Note to set blank values to nil before validation.
-
Yorick Peterse authored
We can just use "arel_table" in these cases instead of "SomeClass.arel_table".
-
Yorick Peterse authored
-
- 06 Mar, 2016 2 commits
-
-
Robert Speicher authored
-
Robert Speicher authored
We've got all these polymorphic type-checking methods, might as well use 'em everywhere it makes sense.
-
- 05 Mar, 2016 2 commits
-
-
Robert Speicher authored
This method was duplicating default Rails behavior.
-
Robert Speicher authored
This method was added in Dec 2012, its single use was removed two days later, and it's been there ever since.
-
- 03 Mar, 2016 1 commit
-
-
Jacob Vosmaer authored
-
- 20 Feb, 2016 3 commits
-
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
- 19 Feb, 2016 2 commits
-
-
Zeger-Jan van de Weg authored
-
Zeger-Jan van de Weg authored
-
- 22 Jan, 2016 1 commit
-
-
Douwe Maan authored
-
- 19 Jan, 2016 1 commit
-
-
Rubén Dávila authored
-
- 13 Jan, 2016 1 commit
-
-
Rémy Coutable authored
This is moved to a model method rather than an helper method because the API will need it too.
-
- 29 Dec, 2015 1 commit
-
-
Valery Sizov authored
-
- 28 Dec, 2015 1 commit
-
-
Valery Sizov authored
-
- 25 Dec, 2015 1 commit
-
-
Valery Sizov authored
-
- 15 Dec, 2015 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- 11 Dec, 2015 1 commit
-
-
Valery Sizov authored
-
- 10 Dec, 2015 1 commit
-
-
Valery Sizov authored
-
- 09 Dec, 2015 1 commit
-
-
Stan Hu authored
-
- 07 Dec, 2015 2 commits
-
-
Robert Speicher authored
-
Grzegorz Bizon authored
-
- 05 Dec, 2015 1 commit
-
-
Grzegorz Bizon authored
-
- 03 Dec, 2015 4 commits
-
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-
Grzegorz Bizon authored
-