- 19 Sep, 2017 1 commit
-
-
Mark Fletcher authored
* Will dry up the code to find projects between the ForksController and the API
-
- 10 Sep, 2017 5 commits
-
-
Maxim Rydkin authored
-
Maxim Rydkin authored
-
Maxim Rydkin authored
-
Maxim Rydkin authored
-
Maxim Rydkin authored
-
- 07 Sep, 2017 1 commit
-
-
Tiago Botelho authored
-
- 05 Sep, 2017 1 commit
-
-
Yorick Peterse authored
This changes the issue and MR index pages so the pagination system re-uses the output of the COUNT(*) query used to calculate the number of rows per state (opened, closed, etc). This removes the need for an additional COUNT(*) on both pages.
-
- 30 Aug, 2017 1 commit
-
-
Hiroyuki Sato authored
-
- 24 Aug, 2017 1 commit
-
-
Mehdi Lahmam authored
Closes #35994
-
- 11 Aug, 2017 1 commit
-
-
Tiago Botelho authored
-
- 10 Aug, 2017 2 commits
-
-
Lin Jen-Shin authored
Also fix a few tests
-
Yorick Peterse authored
This commit migrates events data in such a way that push events are stored much more efficiently. This is done by creating a shadow table called "events_for_migration", and a table called "push_event_payloads" which is used for storing push data of push events. The background migration in this commit will copy events from the "events" table into the "events_for_migration" table, push events in will also have a row created in "push_event_payloads". This approach allows us to reclaim space in the next release by simply swapping the "events" and "events_for_migration" tables, then dropping the old events (now "events_for_migration") table. The new table structure is also optimised for storage space, and does not include the unused "title" column nor the "data" column (since this data is moved to "push_event_payloads"). == Newly Created Events Newly created events are inserted into both "events" and "events_for_migration", both using the exact same primary key value. The table "push_event_payloads" in turn has a foreign key to the _shadow_ table. This removes the need for recreating and validating the foreign key after swapping the tables. Since the shadow table also has a foreign key to "projects.id" we also don't have to worry about orphaned rows. This approach however does require some additional storage as we're duplicating a portion of the events data for at least 1 release. The exact amount is hard to estimate, but for GitLab.com this is expected to be between 10 and 20 GB at most. The background migration in this commit deliberately does _not_ update the "events" table as doing so would put a lot of pressure on PostgreSQL's auto vacuuming system. == Supporting Both Old And New Events Application code has also been adjusted to support push events using both the old and new data formats. This is done by creating a PushEvent class which extends the regular Event class. Using Rails' Single Table Inheritance system we can ensure the right class is used for the right data, which in this case is based on the value of `events.action`. To support displaying old and new data at the same time the PushEvent class re-defines a few methods of the Event class, falling back to their original implementations for push events in the old format. Once all existing events have been migrated the various push event related methods can be removed from the Event model, and the calls to `super` can be removed from the methods in the PushEvent model. The UI and event atom feed have also been slightly changed to better handle this new setup, fortunately only a few changes were necessary to make this work. == API Changes The API only displays push data of events in the new format. Supporting both formats in the API is a bit more difficult compared to the UI. Since the old push data was not really well documented (apart from one example that used an incorrect "action" nmae) I decided that supporting both was not worth the effort, especially since events will be migrated in a few days _and_ new events are created in the correct format.
-
- 02 Aug, 2017 1 commit
-
-
Robert Speicher authored
-
- 01 Aug, 2017 1 commit
-
-
Robert Speicher authored
-
- 27 Jul, 2017 1 commit
-
-
Rémy Coutable authored
Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 24 Jul, 2017 2 commits
-
-
Robert Speicher authored
-
Maxim Rydkin authored
-
- 07 Jul, 2017 4 commits
-
-
Felipe Artur authored
-
James Lopez authored
-
James Lopez authored
-
James Lopez authored
-
- 30 Jun, 2017 3 commits
-
-
Horacio Bertorello authored
-
Sean McGivern authored
-
Sean McGivern authored
When we are filtering by a single project, and the current user has access to see confidential issues on that project, we don't need to filter by confidentiality at all - just as if the user were an admin. The filter by confidentiality often picks a non-optimal query plan: for instance, AND-ing the results of all issues in the project (a relatively small set), and all issues in the states requested (a huge set), rather than just starting small and winnowing further.
-
- 18 Jun, 2017 1 commit
-
-
Kyle Bishop authored
-
- 16 Jun, 2017 1 commit
-
-
Stan Hu authored
The spec was trying to sort pipelines by user ID, but the same user ID was being used for each pipeline in the spec. This is similar to #33001.
-
- 15 Jun, 2017 2 commits
-
-
Toon Claes authored
Ensure the results match exactly and project authorizations do allow access to sibling groups/projects deeper down. Also apply WHERE scopes before running the UNION, to increase performance.
-
Toon Claes authored
When a user is authorized to a group, they are also authorized to see all the ancestor groups and descendant groups. When a user is authorized to a project, they are authorized to see all the ancestor groups too. Closes #32135 See merge request !11764
-
- 14 Jun, 2017 1 commit
-
-
Robert Speicher authored
-
- 06 Jun, 2017 1 commit
-
-
Mark Fletcher authored
* Meld the following disparate endpoints: * `/projects/:id/events` * `/events` * `/users/:id/events` + Add result filtering to the above endpoints: * action * target_type * before and after dates
-
- 30 May, 2017 2 commits
-
-
Toon Claes authored
And use it in the API.
-
Toon Claes authored
The `starred` parameter couldn't be used in combination with `trending` or `non_public`. But this is changed now.
-
- 17 May, 2017 1 commit
-
-
Yorick Peterse authored
This commit introduces the usage of Common Table Expressions (CTEs) to efficiently retrieve nested group hierarchies, without having to rely on the "routes" table (which is an _incredibly_ inefficient way of getting the data). This requires a patch to ActiveRecord (found in the added initializer) to work properly as ActiveRecord doesn't support WITH statements properly out of the box. Unfortunately MySQL provides no efficient way of getting nested groups. For example, the old routes setup could easily take 5-10 seconds depending on the amount of "routes" in a database. Providing vastly different logic for both MySQL and PostgreSQL will negatively impact the development process. Because of this the various nested groups related methods return empty relations when used in combination with MySQL. For project authorizations the logic is split up into two classes: * Gitlab::ProjectAuthorizations::WithNestedGroups * Gitlab::ProjectAuthorizations::WithoutNestedGroups Both classes get the fresh project authorizations (= as they should be in the "project_authorizations" table), including nested groups if PostgreSQL is used. The logic of these two classes is quite different apart from their public interface. This complicates development a bit, but unfortunately there is no way around this. This commit also introduces Gitlab::GroupHierarchy. This class can be used to get the ancestors and descendants of a base relation, or both by using a UNION. This in turn is used by methods such as: * Namespace#ancestors * Namespace#descendants * User#all_expanded_groups Again this class relies on CTEs and thus only works on PostgreSQL. The Namespace methods will return an empty relation when MySQL is used, while User#all_expanded_groups will return only the groups a user is a direct member of. Performance wise the impact is quite large. For example, on GitLab.com Namespace#descendants used to take around 580 ms to retrieve data for a particular user. Using CTEs we are able to reduce this down to roughly 1 millisecond, returning the exact same data. == On The Fly Refreshing Refreshing of authorizations on the fly (= when users.authorized_projects_populated was not set) is removed with this commit. This simplifies the code, and ensures any queries used for authorizations are not mutated because they are executed in a Rails scope (e.g. Project.visible_to_user). This commit includes a migration to schedule refreshing authorizations for all users, ensuring all of them have their authorizations in place. Said migration schedules users in batches of 5000, with 5 minutes between every batch to smear the load around a bit. == Spec Changes This commit also introduces some changes to various specs. For example, some specs for ProjectTeam assumed that creating a personal project would _not_ lead to the owner having access, which is incorrect. Because we also no longer refresh authorizations on the fly for new users some code had to be added to the "empty_project" factory. This chunk of code ensures that the owner's permissions are refreshed after creating the project, something that is normally done in Projects::CreateService.
-
- 15 May, 2017 2 commits
-
-
Bob Van Landuyt authored
-
George Andrinopoulos authored
-
- 10 May, 2017 3 commits
-
-
Bob Van Landuyt authored
-
Douwe Maan authored
Use GroupsFinder to find subgroups the user has access to See merge request !2096
-
Douwe Maan authored
Refactor snippets finder & dont return internal snippets for external users See merge request !2094
-
- 07 May, 2017 1 commit
-
-
Zeger-Jan van de Weg authored
-