- 27 Jul, 2017 1 commit
-
-
Keifer Furzland authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 22 May, 2017 1 commit
-
-
Felipe Artur authored
-
- 08 May, 2017 1 commit
-
-
Felipe Artur authored
-
- 01 Feb, 2017 1 commit
-
- 26 Jan, 2017 1 commit
-
-
Robert Speicher authored
-
- 17 Jan, 2017 2 commits
-
-
James Lopez authored
-
James Lopez authored
-
- 29 Nov, 2016 1 commit
-
-
Douwe Maan authored
Fix missing access checks on issue lookup using IssuableFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867
- Potentially untested - No test coverage - Test coverage of some sort exists (a test failed when error raised) - Test coverage of return value (a test failed when nil used) - Permissions check tested - [x] app/controllers/projects/branches_controller.rb:39 - `before_action :authorize_push_code!` helpes limit/prevent exploitation. Always checks for reporter access so fine with confidential issues, issues only visible to team, etc. - [x] app/models/cycle_analytics/summary.rb:9 [`.count`] - [x] app/controllers/projects/todos_controller.rb:19 - [x] Potential double render in app/controllers/projects/todos_controller.rb - https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#cedccb227af9bfdf88802767cb58d43c2b977439_24_24 See merge request !2030
-
- 21 Nov, 2016 2 commits
-
-
James Lopez authored
-
James Lopez authored
-
- 12 Oct, 2016 2 commits
-
-
James Lopez authored
-
James Lopez authored
Also, updated specs and docs.
-
- 20 Sep, 2016 2 commits
-
-
Timothy Andrew authored
- Don't use `TableReferences` - using `.arel_table` is shorter! - Move some database-related code to `Gitlab::Database` - Remove the `MergeRequest#issues_closed` and `Issue#closed_by_merge_requests` associations. They were either shadowing or were too similar to existing methods. They are not being used anywhere, so it's better to remove them to reduce confusion. - Use Rails 3-style validations - Index for `MergeRequest::Metrics#first_deployed_to_production_at` - Only include `CycleAnalyticsHelpers::TestGeneration` for specs that need it. - Other minor refactorings.
-
Timothy Andrew authored
A number of failures were introduced due to performance improvements (like pre-calculating metrics).
-
- 07 Sep, 2016 2 commits
-
-
Timothy Andrew authored
1. Move the test generation to `CycleAnalyticsHelpers::TestGeneration` 2. Move all helper methods (previously placed in each individual spec file) to `CycleAnalyticsHelpers`
-
Timothy Andrew authored
-