- 05 Jan, 2017 1 commit
-
-
Grzegorz Bizon authored
-
- 03 Jan, 2017 9 commits
-
-
Jose Ivan Vargas authored
Reverted the change from the "expires_at" to "expires_at_groups" in the groups controller
-
Jose Ivan Vargas authored
Fixed more tests
-
Jose Ivan Vargas authored
-
Jose Ivan Vargas authored
-
Jose Ivan Vargas authored
view (removed an extra tag )
-
Jose Ivan Vargas authored
This controller is going to contain both the project members and groups options for the settings gear. Generated the route and modified the routing to point to the new members setting path
-
Z.J. van de Weg authored
-
Z.J. van de Weg authored
-
Kamil Trzcinski authored
-
- 31 Dec, 2016 1 commit
-
-
Sam Rose authored
-
- 28 Dec, 2016 1 commit
-
-
Sam Rose authored
Fix spacing between nav control elements Wrap navigation text on Tags list page
-
- 23 Dec, 2016 1 commit
-
-
Tiago Botelho authored
-
- 21 Dec, 2016 5 commits
-
-
Tiago Botelho authored
-
Tiago Botelho authored
-
Filipa Lacerda authored
Fix broken test Remove spinach tests for the builds tab
-
Filipa Lacerda authored
Remove unused file Fix commit link
-
Filipa Lacerda authored
Fix specs
-
- 20 Dec, 2016 2 commits
-
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
- 19 Dec, 2016 6 commits
-
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
- Add proper error handling, - Use flash[:alert] and flash[:notice], - Use `resource` instead of `resources`,
-
Fatih Acet authored
-
Z.J. van de Weg authored
[ci skip]
-
Nick Thomas authored
-
Kamil Trzcinski authored
``` Endpoint: /group/project/pipelines/id/stage.json?stage=name Call: stage_namespace_project_pipeline_path(pipeline.project.namespace, pipeline.project, pipeline, stage: stage.name) ```
-
- 18 Dec, 2016 1 commit
-
-
Jeff Stubler authored
Closes #25761.
-
- 16 Dec, 2016 7 commits
-
-
Douglas Barbosa Alexandre authored
-
Nur Rony authored
-
Z.J. van de Weg authored
-
Z.J. van de Weg authored
-
Z.J. van de Weg authored
-
Z.J. van de Weg authored
-
Z.J. van de Weg authored
-
- 15 Dec, 2016 4 commits
-
-
Kamil Trzcinski authored
-
Luke Bennett authored
Finished up autocomplete_sources action and added frontend to fetch data only when its needed Added wait_for_ajax to specs Fixed builds and improved the setup/destroy lifecycle Changed global namespace and DRYed up loading logic Added safety for accidentally loading data twice Removed destroy as its not necessary and is messing with click events from a blur race condition Created AutocompleteSourcesController and updated routes Fixed @undefined from tabbing before load ends Disable tabSelectsMatch until we have loaded data Review changes
-
Douwe Maan authored
Fix missing Note access checks in by moving Note#search to updated NoteFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ## Which fixes are in this MR?
- Potentially untested - No test coverage - Test coverage of some sort exists (a test failed when error raised) - Test coverage of return value (a test failed when nil used) - Permissions check tested ### Note lookup without access check - [x] app/finders/notes_finder.rb:13 :download_code check - [x] app/finders/notes_finder.rb:19 `SnippetsFinder` - [x] app/models/note.rb:121 [`Issue#visible_to_user`] - [x] lib/gitlab/project_search_results.rb:113 - This is the only use of `app/models/note.rb:121` above, but importantly has no access checks at all. This means it leaks MR comments and snippets when those features are `team-only` in addition to the issue comments which would be fixed by `app/models/note.rb:121`. - It is only called from SearchController where `can?(current_user, :download_code, @project)` is checked, so commit comments are not leaked. ### Previous discussions - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b915c5267a63628b0bafd23d37792ae73ceae272_13_13 `: download_code` check on commit - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b915c5267a63628b0bafd23d37792ae73ceae272_19_19 `SnippetsFinder` should be used - `SnippetsFinder` should check if the snippets feature is enabled -> https://gitlab.com/gitlab-org/gitlab-ce/issues/25223 ### Acceptance criteria met? - [x] Tests added for new code - [x] TODO comments removed - [x] Squashed and removed skipped tests - [x] Changelog entry - [ ] State Gitlab versions affected and issue severity in description - [ ] Create technical debt issue for NotesFinder. - Either split into `NotesFinder::ForTarget` and `NotesFinder::Search` or consider object per notable type such as `NotesFinder::OnIssue`. For the first option could create `NotesFinder::Base` which is either inherited from or which can be included in the other two. - Avoid case statement anti-pattern in this finder with use of `NotesFinder::OnCommit` etc. Consider something on the finder for this? `Model.finder(user, project)` - Move `inc_author` to the controller, and implement `related_notes` to replace `non_diff_notes`/`mr_and_commit_notes` See merge request !2035 -
Grzegorz Bizon authored
-
- 12 Dec, 2016 1 commit
-
-
Felipe Artur authored
-
- 10 Dec, 2016 1 commit
-
-
Mike Greiling authored
-