BigW Consortium Gitlab

  1. 07 Dec, 2017 1 commit
  2. 05 Dec, 2017 1 commit
  3. 01 Dec, 2017 1 commit
  4. 24 Nov, 2017 1 commit
  5. 23 Nov, 2017 1 commit
  6. 06 Nov, 2017 1 commit
  7. 03 Nov, 2017 1 commit
  8. 02 Nov, 2017 1 commit
  9. 05 Oct, 2017 1 commit
  10. 04 Oct, 2017 2 commits
  11. 05 Sep, 2017 1 commit
    • Optimize SQL queries used in Groups::GroupMembersController#create · 66cfb901
      Rubén Dávila authored
      The following optimizations were performed:
      
      - Add new association to GroupMember and ProjectMember
      
        This new association will allow us to check if a user is a member of a
        Project or Group through a single query instead of two.
      
      - Optimize retrieving of Members when adding multiple Users
  12. 30 Aug, 2017 1 commit
  13. 29 Aug, 2017 1 commit
  14. 26 Aug, 2017 6 commits
  15. 25 Aug, 2017 1 commit
    • Move sidekiq-based project authorization refresh out of Projects::CreateService · 8b73df0c
      Nick Thomas authored
      If the project is in a group, the `group.refresh_members_authorized_projects`
      is made non-blocking, and we call `current_user.refresh_authorized_projects`
      directly.
      
      Projects in a personal namespace are more difficult. Rather than passing the
      `blocking:` parameter through the entire `add_master` chain, have the
      `AuthorizedProjectsWorker` automatically inline authorizations for three IDs or
      less. Since the maximum number of IDs in this path is 2, that has the same effect.
  16. 14 Aug, 2017 1 commit
  17. 24 Jul, 2017 1 commit
  18. 17 Jul, 2017 1 commit
  19. 07 Jul, 2017 5 commits
    • Native group milestones · b5f596c3
      Felipe Artur authored
    • Use ancestors for avoiding N queries · bd846f7d
      Shinya Maeda authored
    • Basic BE change · 5b095475
      Shinya Maeda authored
      Fix static-snalysis
      
      Move the precedence of group secure variable before project secure variable. Allow project_id to be null.
      
      Separate Ci::VariableProject and Ci::VariableGroup
      
      Add the forgotton files
      
      Add migration file to update type of ci_variables
      
      Fix form_for fpr VariableProject
      
      Fix test
      
      Change the table structure according to the yorik advice
      
      Add necessary migration files. Remove unnecessary migration spec.
      
      Revert safe_model_attributes.yml
      
      Fix models
      
      Fix spec
      
      Avoid self.variable. Use becomes for correct routing.
      
      Use unique index on group_id and key
      
      Add null: false for t.timestamps
      
      Fix schema version
      
      Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable
      
      Rename the rest of them
      
      Add the rest of files
      
      Basic BE change
      
      Fix static-snalysis
      
      Move the precedence of group secure variable before project secure variable. Allow project_id to be null.
      
      Separate Ci::VariableProject and Ci::VariableGroup
      
      Add the forgotton files
      
      Add migration file to update type of ci_variables
      
      Fix form_for fpr VariableProject
      
      Fix test
      
      Change the table structure according to the yorik advice
      
      Add necessary migration files. Remove unnecessary migration spec.
      
      Revert safe_model_attributes.yml
      
      Fix models
      
      Fix spec
      
      Avoid self.variable. Use becomes for correct routing.
      
      Use unique index on group_id and key
      
      Add null: false for t.timestamps
      
      Fix schema version
      
      Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable
      
      Rename the rest of them
      
      Add the rest of files
      
      Implement CURD
      
      Rename codes related to VariableGroup and VariableProject FE part
      
      Remove unneccesary changes
      
      Make Fe code up-to-date
      
      Add protected flag to migration file
      
      Protected group variables essential package
      
      Update schema
      
      Improve doc
      
      Fix logic and spec for models
      
      Fix logic and spec for controllers
      
       Fix logic and spec for views(pre feature)
      
      Add feature spec
      
      Fixed bugs. placeholder. reveal button. doc.
      
      Add changelog
      
      Remove unnecessary comment
      
      godfat nice catches
      
      Improve secret_variables_for arctecture
      
      Fix spec
      
      Fix StaticAnlysys & path_regex spec
      
      Revert "Improve secret_variables_for arctecture"
      
      This reverts commit c3216ca212322ecf6ca534cb12ce75811a4e77f1.
      
      Use ayufan suggestion for secret_variables_for
      
      Use find instead of find_by
      
      Fix spec message for variable is invalid
      
      Fix spec remove variable.group_id = group.id
      
      godffat spec nitpicks
      
      Use include Gitlab::Routing.url_helpers for presenter spec
  20. 06 Jul, 2017 1 commit
    • Added Cop to blacklist the use of `dependent:` · 8fbbf41e
      Yorick Peterse authored
      This is allowed for existing instances so we don't end up 76 offenses
      right away, but for new code one should _only_ use this if they _have_
      to remove non database data. Even then it's usually better to do this in
      a service class as this gives you more control over how to remove the
      data (e.g. in bulk).
  21. 28 Jun, 2017 1 commit
  22. 21 Jun, 2017 1 commit
  23. 05 Jun, 2017 1 commit
    • Allow group reporters to manage group labels · 5db229fb
      Sean McGivern authored
      Previously, only group masters could do this. However, project reporters can
      manage project labels, so there doesn't seem to be any need to restrict group
      labels further.
      
      Also, save a query or two by getting a single GroupMember object to find out if
      the user is a master or not.
  24. 17 May, 2017 1 commit
    • Use CTEs for nested groups and authorizations · ac382b56
      Yorick Peterse authored
      This commit introduces the usage of Common Table Expressions (CTEs) to
      efficiently retrieve nested group hierarchies, without having to rely on
      the "routes" table (which is an _incredibly_ inefficient way of getting
      the data). This requires a patch to ActiveRecord (found in the added
      initializer) to work properly as ActiveRecord doesn't support WITH
      statements properly out of the box.
      
      Unfortunately MySQL provides no efficient way of getting nested groups.
      For example, the old routes setup could easily take 5-10 seconds
      depending on the amount of "routes" in a database. Providing vastly
      different logic for both MySQL and PostgreSQL will negatively impact the
      development process. Because of this the various nested groups related
      methods return empty relations when used in combination with MySQL.
      
      For project authorizations the logic is split up into two classes:
      
      * Gitlab::ProjectAuthorizations::WithNestedGroups
      * Gitlab::ProjectAuthorizations::WithoutNestedGroups
      
      Both classes get the fresh project authorizations (= as they should be
      in the "project_authorizations" table), including nested groups if
      PostgreSQL is used. The logic of these two classes is quite different
      apart from their public interface. This complicates development a bit,
      but unfortunately there is no way around this.
      
      This commit also introduces Gitlab::GroupHierarchy. This class can be
      used to get the ancestors and descendants of a base relation, or both by
      using a UNION. This in turn is used by methods such as:
      
      * Namespace#ancestors
      * Namespace#descendants
      * User#all_expanded_groups
      
      Again this class relies on CTEs and thus only works on PostgreSQL. The
      Namespace methods will return an empty relation when MySQL is used,
      while User#all_expanded_groups will return only the groups a user is a
      direct member of.
      
      Performance wise the impact is quite large. For example, on GitLab.com
      Namespace#descendants used to take around 580 ms to retrieve data for a
      particular user. Using CTEs we are able to reduce this down to roughly 1
      millisecond, returning the exact same data.
      
      == On The Fly Refreshing
      
      Refreshing of authorizations on the fly (= when
      users.authorized_projects_populated was not set) is removed with this
      commit. This simplifies the code, and ensures any queries used for
      authorizations are not mutated because they are executed in a Rails
      scope (e.g. Project.visible_to_user).
      
      This commit includes a migration to schedule refreshing authorizations
      for all users, ensuring all of them have their authorizations in place.
      Said migration schedules users in batches of 5000, with 5 minutes
      between every batch to smear the load around a bit.
      
      == Spec Changes
      
      This commit also introduces some changes to various specs. For example,
      some specs for ProjectTeam assumed that creating a personal project
      would _not_ lead to the owner having access, which is incorrect. Because
      we also no longer refresh authorizations on the fly for new users some
      code had to be added to the "empty_project" factory. This chunk of code
      ensures that the owner's permissions are refreshed after creating the
      project, something that is normally done in Projects::CreateService.
  25. 10 May, 2017 1 commit
  26. 21 Apr, 2017 1 commit
  27. 06 Apr, 2017 1 commit
  28. 21 Mar, 2017 1 commit
  29. 06 Mar, 2017 1 commit
  30. 02 Mar, 2017 1 commit