- 04 Sep, 2017 3 commits
-
-
Zeger-Jan van de Weg authored
-
Zeger-Jan van de Weg authored
-
Zeger-Jan van de Weg authored
-
- 31 Aug, 2017 4 commits
-
-
Zeger-Jan van de Weg authored
-
Zeger-Jan van de Weg authored
Behind an application setting, which defaults to false, this commit implements the implied CI/CD config. Which means that in the case we can't find the `.gitlab-ci.yml` on the commit we want to start a pipeline for, we fall back to an implied configuration. For now the Bash template has been copied to `Auto-Devops.gitlab-ci.yml` so the tests actually work. Fixes #34777
-
Sean McGivern authored
The initializers including this were doing so at the top level, so every object loaded after them had a `current_application_settings` method. However, if someone had rack-attack enabled (which was loaded before these initializers), it would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't have that method. To fix this: 1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need `Object.new.current_application_settings` to work. 2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it like that in several places. 3. Change the initializers to use that new form.
-
Zeger-Jan van de Weg authored
In this instance its subgroups, and given we can't deploy it, we shouldn't allow it to be shown. Fixes gitlab-org/gitlab-ce#34864
-
- 30 Aug, 2017 1 commit
-
-
Mike Greiling authored
-
- 29 Aug, 2017 1 commit
-
-
Rubén Dávila authored
-
- 25 Aug, 2017 2 commits
-
-
Gabriel Mazetto authored
There are some redundancies in the validation steps, and that is to preserve current error messages behavior Also few specs have to be changed in order to fix madness in validation logic.
-
Lin Jen-Shin authored
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13766 * Rename AfterImportService * Use constants * Move Git operations to Gitlab::Git::Repository * Use Regexp.union
-
- 24 Aug, 2017 2 commits
-
-
Lin Jen-Shin authored
-
Mehdi Lahmam authored
Closes #35994
-
- 23 Aug, 2017 2 commits
-
-
Lin Jen-Shin authored
Because we don't need them, and they would slow down the repository, keeping unneeded objects as well. We could also consider doing this in regular housekeeping.
-
Yorick Peterse authored
Every project page displays a navigation menu that in turn displays the number of open issues and merge requests. This means that for every project page we run two COUNT(*) queries, each taking up roughly 30 milliseconds on GitLab.com. By caching these numbers and refreshing them whenever necessary we can reduce loading times of all these pages by up to roughly 60 milliseconds. The number of open issues does not include confidential issues. This is a trade-off to keep the code simple and to ensure refreshing the data only needs 2 COUNT(*) queries instead of 3. A downside is that if a project only has 5 confidential issues the counter will be set to 0. Because we now have 3 similar counting service classes the code previously used in Projects::ForksCountService has mostly been moved to Projects::CountService, which in turn is reused by the various service classes. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/36622
-
- 22 Aug, 2017 11 commits
-
-
Gabriel Mazetto authored
-
Gabriel Mazetto authored
-
Gabriel Mazetto authored
-
Gabriel Mazetto authored
-
Gabriel Mazetto authored
-
Gabriel Mazetto authored
Using `extend` dynamically can lead to bad performance as it invalidates the method's cache.
-
Gabriel Mazetto authored
-
Gabriel Mazetto authored
-
Gabriel Mazetto authored
-
Gabriel Mazetto authored
-
Gabriel Mazetto authored
-
- 18 Aug, 2017 1 commit
-
-
blackst0ne authored
-
- 17 Aug, 2017 3 commits
-
-
Tiago Botelho authored
Backports EE mirror stuck handling feature (https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2628) to CE
-
Nick Thomas authored
-
Nick Thomas authored
-
- 15 Aug, 2017 1 commit
-
-
vanadium23 authored
-
- 14 Aug, 2017 2 commits
-
-
Robert Speicher authored
An upcoming update to rubocop-gitlab-security added additional violations.
-
Yorick Peterse authored
The number of forks of a project doesn't change very frequently and running a COUNT(*) every time this information is requested can be quite expensive. We also end up running such a COUNT(*) query at least twice on the homepage of a project. By caching this data and refreshing it when necessary we can reduce project homepage loading times by around 60 milliseconds (based on the timings of https://gitlab.com/gitlab-org/gitlab-ce).
-
- 10 Aug, 2017 1 commit
-
-
Lin Jen-Shin authored
so that we don't have to fetch it for non-forks
-
- 08 Aug, 2017 2 commits
-
-
Brian Neel authored
-
blackst0ne authored
-
- 07 Aug, 2017 1 commit
-
- 04 Aug, 2017 1 commit
-
-
Jacob Vosmaer authored
-
- 01 Aug, 2017 2 commits
-
-
Z.J. van de Weg authored
First round of review, main changes: - templates.title is human readable, #name will be passed around - GitLabProjectImporterService has been renamed
-
Gabriel Mazetto authored
-