- 27 Jan, 2016 1 commit
-
-
Yorick Peterse authored
By simply loading the first event from the already sorted set we save ourselves extra (slow) queries just to get the latest update timestamp. This removes the need for Event.latest_update_time and significantly reduces the time needed to build an Atom feed. Fixes gitlab-org/gitlab-ce#12415
-
- 09 Dec, 2015 1 commit
-
-
Douwe Maan authored
-
- 18 Nov, 2015 2 commits
-
-
Yorick Peterse authored
This will be used to move some querying logic from the users controller to the Event model (where it belongs).
-
Yorick Peterse authored
Instead of using MAX(events.updated_at) we can simply sort the events in descending order by the "id" column and grab the first row. In other words, instead of this: SELECT max(events.updated_at) AS max_id FROM events LEFT OUTER JOIN projects ON projects.id = events.project_id LEFT OUTER JOIN namespaces ON namespaces.id = projects.namespace_id WHERE events.author_id IS NOT NULL AND events.project_id IN (13083); we can use this: SELECT events.updated_at AS max_id FROM events LEFT OUTER JOIN projects ON projects.id = events.project_id LEFT OUTER JOIN namespaces ON namespaces.id = projects.namespace_id WHERE events.author_id IS NOT NULL AND events.project_id IN (13083) ORDER BY events.id DESC LIMIT 1; This has the benefit that on PostgreSQL a backwards index scan can be used, which due to the "LIMIT 1" will at most process only a single row. This in turn greatly speeds up the process of grabbing the latest update time. This can be confirmed by looking at the query plans. The first query produces the following plan: Aggregate (cost=43779.84..43779.85 rows=1 width=12) (actual time=2142.462..2142.462 rows=1 loops=1) -> Index Scan using index_events_on_project_id on events (cost=0.43..43704.69 rows=30060 width=12) (actual time=0.033..2138.086 rows=32769 loops=1) Index Cond: (project_id = 13083) Filter: (author_id IS NOT NULL) Planning time: 1.248 ms Execution time: 2142.548 ms The second query in turn produces the following plan: Limit (cost=0.43..41.65 rows=1 width=16) (actual time=1.394..1.394 rows=1 loops=1) -> Index Scan Backward using events_pkey on events (cost=0.43..1238907.96 rows=30060 width=16) (actual time=1.394..1.394 rows=1 loops=1) Filter: ((author_id IS NOT NULL) AND (project_id = 13083)) Rows Removed by Filter: 2104 Planning time: 0.166 ms Execution time: 1.408 ms According to the above plans the 2nd query is around 1500 times faster. However, re-running the first query produces timings of around 80 ms, making the 2nd query "only" around 55 times faster.
-
- 12 Feb, 2015 1 commit
-
-
Jeroen van Baarsen authored
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
-
- 03 Nov, 2014 2 commits
-
-
Ciro Santilli authored
-
Ciro Santilli authored
-
- 17 Jun, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 09 Apr, 2014 1 commit
-
-
Dmitriy Zaporozhets authored
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
-
- 14 Dec, 2013 1 commit
-
-
skv authored
-
- 26 Mar, 2013 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 13 Feb, 2013 1 commit
-
-
Andrew8xx8 authored
-
- 14 Dec, 2012 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 19 Nov, 2012 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 13 Nov, 2012 1 commit
-
-
Vincent Bonmalais authored
-
- 09 Oct, 2012 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 14 Sep, 2012 1 commit
-
-
randx authored
-
- 09 Sep, 2012 2 commits
-
-
Alex Denisov authored
-
Alex Denisov authored
-
- 02 Sep, 2012 1 commit
-
-
Sytse Sijbrandij authored
Merge branch 'master' into non-interactive-aws-install Conflicts: doc/installation.md Fix merge mess in installation.md
-
- 29 Aug, 2012 3 commits
-
-
Robert Speicher authored
-
Robert Speicher authored
-
Robert Speicher authored
-
- 10 Aug, 2012 1 commit
-
-
Robert Speicher authored
Didn't bother with files in db/, config/, or features/
-
- 26 Jun, 2012 1 commit
-
-
randx authored
-
- 02 Apr, 2012 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 28 Mar, 2012 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 29 Feb, 2012 1 commit
-
-
Dmitriy Zaporozhets authored
Observe issue, merge request, note creation - create event register push event
-
- 28 Feb, 2012 2 commits
-
-
Dmitriy Zaporozhets authored
-
Dmitriy Zaporozhets authored
-
- 15 Feb, 2012 1 commit
-
-
Dmitriy Zaporozhets authored
ProtectedBranches model, Master permission for repo\n Allow push to protected branch for masters only
-