- 01 Feb, 2017 1 commit
-
- 26 Jan, 2017 1 commit
-
-
Robert Speicher authored
-
- 17 Jan, 2017 2 commits
-
-
James Lopez authored
-
James Lopez authored
-
- 29 Nov, 2016 1 commit
-
-
Douwe Maan authored
Fix missing access checks on issue lookup using IssuableFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867
- Potentially untested - No test coverage - Test coverage of some sort exists (a test failed when error raised) - Test coverage of return value (a test failed when nil used) - Permissions check tested - [x] app/controllers/projects/branches_controller.rb:39 - `before_action :authorize_push_code!` helpes limit/prevent exploitation. Always checks for reporter access so fine with confidential issues, issues only visible to team, etc. - [x] app/models/cycle_analytics/summary.rb:9 [`.count`] - [x] app/controllers/projects/todos_controller.rb:19 - [x] Potential double render in app/controllers/projects/todos_controller.rb - https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#cedccb227af9bfdf88802767cb58d43c2b977439_24_24 See merge request !2030
-
- 21 Nov, 2016 2 commits
-
-
James Lopez authored
-
James Lopez authored
-
- 12 Oct, 2016 1 commit
-
-
James Lopez authored
Also, updated specs and docs.
-
- 20 Sep, 2016 2 commits
-
-
Timothy Andrew authored
- Don't use `TableReferences` - using `.arel_table` is shorter! - Move some database-related code to `Gitlab::Database` - Remove the `MergeRequest#issues_closed` and `Issue#closed_by_merge_requests` associations. They were either shadowing or were too similar to existing methods. They are not being used anywhere, so it's better to remove them to reduce confusion. - Use Rails 3-style validations - Index for `MergeRequest::Metrics#first_deployed_to_production_at` - Only include `CycleAnalyticsHelpers::TestGeneration` for specs that need it. - Other minor refactorings.
-
Timothy Andrew authored
A number of failures were introduced due to performance improvements (like pre-calculating metrics).
-
- 07 Sep, 2016 1 commit
-
-
Timothy Andrew authored
- Move the "data belongs to other project" test case into the generated tests, and remove the explicit tests from the `code` and `plan` phases.
-
- 02 Sep, 2016 2 commits
-
-
Timothy Andrew authored
1. Generalise the specs that will be common across all cycle analytics phases. 2. Rewrite specs `issue` and `plan` to use this abstracted testing strategy. 3. Specs that are specific to a given phase, or unwieldy to test in an abstracted manner, are added to each phase's spec.
-
Timothy Andrew authored
Clean up the `issue` tests as well
-
- 26 Aug, 2016 3 commits
-
-
Timothy Andrew authored
1. Supported date ranges are 30 / 90 days ago. The default is 90 days ago. 2. All issues created before "x days ago" are filtered out, even if they have other related data (test runs, merge requests) within the filter range.
-
Timothy Andrew authored
-
Timothy Andrew authored
-