- 01 Apr, 2016 1 commit
-
-
Yorick Peterse authored
Rails' "url_helpers" method creates an anonymous Module (which a bunch of methods) on every call. By caching the output of this method in a dedicated method we can shave off about 10 seconds of loading time for an issue with around 200 comments.
-
- 19 Jan, 2016 1 commit
-
-
Yorick Peterse authored
This greatly improves the performance of Project#external_issue_tracker by moving most of the fields queried in Ruby to the database and letting the database handle all logic. Prior to this change the process of finding an external issue tracker was along the lines of the following: 1. Load all project services into memory. 2. Reduce the list to only services where "issue_tracker?" returns true 3. Reduce the list from step 2 to service where "default?" returns false 4. Find the first service where "activated?" returns true This has to two big problems: 1. Loading all services into memory only to reduce the list down to a single item later on is a waste of memory (and slow timing wise). 2. Calling Array#select followed by Array#reject followed by Array#find allocates extra objects when this really isn't needed. To work around this the following service fields have been moved to the database (instead of being hardcoded): * category * default This in turn means we can get the external issue tracker using the following query: SELECT * FROM services WHERE active IS TRUE AND default IS FALSE AND category = 'issue_tracker' AND project_id = XXX LIMIT 1 This coupled with memoizing the result (just as before this commit) greatly reduces the time it takes for Project#external_issue_tracker to complete. The exact reduction depends on one's environment, but locally the execution time is reduced from roughly 230 ms to only 2 ms (= a reduction of almost 180x). Fixes gitlab-org/gitlab-ce#10771
-
- 06 Jan, 2016 1 commit
-
-
Stan Hu authored
-
- 26 Aug, 2015 1 commit
-
-
Douwe Maan authored
-
- 25 Apr, 2015 1 commit
-
-
Robert Speicher authored
Closes internal https://dev.gitlab.org/gitlab/gitlabhq/issues/2269
-
- 27 Mar, 2015 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- 06 Mar, 2015 1 commit
-
-
Stan Hu authored
Supports four different event types all bundled under the "note" event type: - comments on a commit - comments on an issue - comments on a merge request - comments on a code snippet
-
- 04 Mar, 2015 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 03 Mar, 2015 1 commit
-
-
Stan Hu authored
1) Adds a DB migration for all services to toggle on push, issue, and merge events. 2) Upon an issue or merge request event, fire service hooks. 3) Slack service supports custom messages for each of these events. Other services not supported at the moment. 4) Label merge request hooks with their corresponding actions.
-
- 24 Feb, 2015 1 commit
-
-
Marin Jankovski authored
Using gitlab url to build links for gitlab issue tracker and add a spec. Fix rubocop warnings in path.
-
- 14 Feb, 2015 1 commit
-
-
Vinnie Okada authored
Make the following changes to deal with new behavior in Rails 4.1.2: * Use nested resources to avoid slashes in arguments to path helpers.
-
- 12 Feb, 2015 1 commit
-
-
Marin Jankovski authored
-
- 02 Feb, 2015 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 28 Jan, 2015 3 commits
-
-
Marin Jankovski authored
-
Marin Jankovski authored
-
Marin Jankovski authored
-