- 02 Mar, 2018 1 commit
-
-
Lin Jen-Shin authored
-
- 07 Feb, 2018 3 commits
-
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
So that we don't need to hold env after the request. This makes it much harder to test, especially Rails session is acting weirdly, so we need `dig('flash', 'flashes', 'alert')` to dig the actual flash value.
-
Lin Jen-Shin authored
after the request. This way, we could release the project referred from the controller, which potentially referred a repository which potentially allocated a lot of memories. Before this change, we could hold the last request data and cannot release the memory. After this change, the largest request data should be able to be collected from GC. This might not impact the instances having heavy load, as the last request should be changing all the time, and GC won't kick in for each request anyway. However it could still potentially allow us to free more memories for each GC runs, because now we could free one more request anyway.
-
- 21 Nov, 2017 3 commits
-
-
digitalMoksha authored
This reverts commit 91075c82.
-
digitalMoksha authored
-
digitalMoksha authored
since `Rails.application.routes.url_helpers` creates a new anonymous module every time it's called
-
- 20 Nov, 2017 1 commit
-
-
Stan Hu authored
In !15082, we changed the behavior of the middleware to call `Rails.application.routes.recognize_path` whenever a new route arrived. However, this can be a CPU-intensive task because Rails needs to allocate memory and compile 850+ different regular expressions, which are complicated in GitLab. As a short-term fix, we can do a lightweight string match before we do the heavier comparison. Closes #40185, gitlab-com/infrastructure#3240
-
- 07 Nov, 2017 1 commit
-
-
Joe Marty authored
- Also remove sign_out DELETE route from read-only whitelist routes
-
- 02 Nov, 2017 1 commit
-
-
Brett Walker authored
-
- 06 Oct, 2017 1 commit
-
-
Toon Claes authored
In GitLab EE, a GitLab instance can be read-only (e.g. when it's a Geo secondary node). But in GitLab CE it also might be useful to have the "read-only" idea around. So port it back to GitLab CE. Also having the principle of read-only in GitLab CE would hopefully lead to less errors introduced, doing write operations when there aren't allowed for read-only calls. Closes gitlab-org/gitlab-ce#37534.
-