- 06 Sep, 2017 1 commit
-
-
micael.bergeron authored
-
- 03 Sep, 2017 1 commit
-
-
Shinya Maeda authored
-
- 17 Aug, 2017 1 commit
-
-
Saverio Miroddi authored
The list of commits must be generated from the merge request, not from a diff of the branches.
-
- 16 Aug, 2017 1 commit
-
-
Saverio Miroddi authored
-
- 10 Aug, 2017 1 commit
-
-
Jacopo authored
Added test to API commits in order to handle cases for authenticated/unauthenticated user in a private and public project.
-
- 08 Aug, 2017 1 commit
-
-
Rémy Coutable authored
Fix the /projects/:id/repository/commits endpoint to handle dots in the ref name when the project full path contains a `/` Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 14 Jun, 2017 1 commit
-
-
Robert Speicher authored
-
- 31 May, 2017 1 commit
-
-
Kamil Trzcinski authored
-
- 17 May, 2017 1 commit
-
-
Yorick Peterse authored
This commit introduces the usage of Common Table Expressions (CTEs) to efficiently retrieve nested group hierarchies, without having to rely on the "routes" table (which is an _incredibly_ inefficient way of getting the data). This requires a patch to ActiveRecord (found in the added initializer) to work properly as ActiveRecord doesn't support WITH statements properly out of the box. Unfortunately MySQL provides no efficient way of getting nested groups. For example, the old routes setup could easily take 5-10 seconds depending on the amount of "routes" in a database. Providing vastly different logic for both MySQL and PostgreSQL will negatively impact the development process. Because of this the various nested groups related methods return empty relations when used in combination with MySQL. For project authorizations the logic is split up into two classes: * Gitlab::ProjectAuthorizations::WithNestedGroups * Gitlab::ProjectAuthorizations::WithoutNestedGroups Both classes get the fresh project authorizations (= as they should be in the "project_authorizations" table), including nested groups if PostgreSQL is used. The logic of these two classes is quite different apart from their public interface. This complicates development a bit, but unfortunately there is no way around this. This commit also introduces Gitlab::GroupHierarchy. This class can be used to get the ancestors and descendants of a base relation, or both by using a UNION. This in turn is used by methods such as: * Namespace#ancestors * Namespace#descendants * User#all_expanded_groups Again this class relies on CTEs and thus only works on PostgreSQL. The Namespace methods will return an empty relation when MySQL is used, while User#all_expanded_groups will return only the groups a user is a direct member of. Performance wise the impact is quite large. For example, on GitLab.com Namespace#descendants used to take around 580 ms to retrieve data for a particular user. Using CTEs we are able to reduce this down to roughly 1 millisecond, returning the exact same data. == On The Fly Refreshing Refreshing of authorizations on the fly (= when users.authorized_projects_populated was not set) is removed with this commit. This simplifies the code, and ensures any queries used for authorizations are not mutated because they are executed in a Rails scope (e.g. Project.visible_to_user). This commit includes a migration to schedule refreshing authorizations for all users, ensuring all of them have their authorizations in place. Said migration schedules users in batches of 5000, with 5 minutes between every batch to smear the load around a bit. == Spec Changes This commit also introduces some changes to various specs. For example, some specs for ProjectTeam assumed that creating a personal project would _not_ lead to the owner having access, which is incorrect. Because we also no longer refresh authorizations on the fly for new users some code had to be added to the "empty_project" factory. This chunk of code ensures that the owner's permissions are refreshed after creating the project, something that is normally done in Projects::CreateService.
-
- 21 Apr, 2017 1 commit
-
-
Jacopo authored
Removed all the unnecessary include of `WaitForAjax` and `ApiHelpers` in the specs. Removed unnecessary usage of `api:true`
-
- 20 Apr, 2017 1 commit
-
-
Douwe Maan authored
-
- 16 Mar, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 14 Mar, 2017 1 commit
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 08 Mar, 2017 2 commits
-
-
Oswaldo Ferreira authored
-
Jordan Ryan Reuter authored
`Kaminari.paginate_array` takes some options, most relevant of which is a `total_count` parameter. Using the `commit_count` for `total_count` lets us correctly treat the return of `Repository#commits` as a subset of all the commits we may wish to list. Addition of a new `Repository#commit_count_for_ref` method was necessarry to allow the user to start from an arbitrary ref. Ref #1381
-
- 23 Feb, 2017 1 commit
-
-
Douwe Maan authored
-
- 21 Feb, 2017 1 commit
-
-
Oswaldo Ferreira authored
-
- 20 Feb, 2017 1 commit
-
-
Robert Schilling authored
-
- 16 Feb, 2017 1 commit
-
-
Robert Schilling authored
-
- 15 Feb, 2017 1 commit
-
-
Mark Fletcher authored
-
- 14 Feb, 2017 1 commit
-
-
Ben Boeckel authored
Fixes #23895.
-
- 26 Jan, 2017 1 commit
-
-
Robert Speicher authored
-
- 03 Jan, 2017 1 commit
-
-
Mark Fletcher authored
-
- 14 Dec, 2016 1 commit
-
-
Rémy Coutable authored
This was because the MR was a bit behind master and the error message got updated in the meantime by 79aad815. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 13 Dec, 2016 2 commits
-
-
Robert Schilling authored
-
Robert Schilling authored
-
- 01 Dec, 2016 1 commit
-
-
Robert Schilling authored
-
- 28 Nov, 2016 1 commit
-
-
Livier authored
Restore changes for api spec files Fix error in rspec Users Delete extra space Repositories-spec
-
- 24 Oct, 2016 1 commit
-
-
Luis HGO authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 11 Oct, 2016 1 commit
-
-
tiagonbotelho authored
-
- 05 Oct, 2016 1 commit
-
-
Marc Siegfriedt authored
add docs and tests - add additional validation allow move without content updated response
-
- 18 Sep, 2016 1 commit
-
-
Kamil Trzcinski authored
-
- 13 Sep, 2016 1 commit
-
- 12 Sep, 2016 1 commit
-
-
Lin Jen-Shin authored
-
- 15 Aug, 2016 1 commit
-
-
Lin Jen-Shin authored
-
- 11 Aug, 2016 2 commits
-
-
Kamil Trzcinski authored
This change simplifies a Pipeline processing by introducing a special new status: created. This status is used for all builds that are created for a pipeline. We are then processing next stages and queueing some of the builds (created -> pending) or skipping them (created -> skipped). This makes it possible to simplify and solve a few ordering problems with how previously builds were scheduled. This also allows us to visualise a full pipeline (with created builds). This also removes an after_touch used for updating a pipeline state parameters. Right now in various places we explicitly call a reload_status! on pipeline to force it to be updated and saved.
-
Lin Jen-Shin authored
-
- 09 Aug, 2016 1 commit
-
-
tiagonbotelho authored
-
- 03 Aug, 2016 1 commit
-
-
Paco Guzman authored
So we have raw_diffs too
-
- 28 Jul, 2016 1 commit
-
-
dixpac authored
-