- 11 May, 2016 3 commits
-
-
Sean McGivern authored
The repository push email can be very expensive to generate, especially with syntax-highlighted diffs. Instead of generating the email for each recipient, generate one email object and reset the Message-Id and To headers for each recipient. (Cloning would also be expensive in the case of large emails, although probably not as bad as generating from scratch.)
-
Connor Shea authored
Also fix one use of `gsub` that would be faster as `delete`. Use `tr` instead of `gsub` when you are replacing the same number of characters. Use `delete` instead of `gsub` when you are deleting characters.
-
Connor Shea authored
Also fixes the errors caused by enabling the cop. casecmp is more performant than `.downcase` and `==`.
-
- 10 May, 2016 1 commit
-
-
Rémy Coutable authored
This reverts commit 4cc85a58, reversing changes made to 90ae445b. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 09 May, 2016 2 commits
-
-
Artem Sidorenko authored
-
Stan Hu authored
If you attempt to push thousands of branches at once, the 60-second timeout will occur because GitAccess checking does a lot of work to check if the user has permission to push to a branch. This changes does two things: 1. Instead of making 1 DB query per branch push, use a memoized list of protected branches to check 2. Memoize what permissions the user has to perform on this project On a test of 10,000 branch pushes, this prevents gitlab-shell from hitting the 60-second timeout. Closes #17225
-
- 07 May, 2016 1 commit
-
-
Stan Hu authored
Use a custom Loofah scrubber since sanitize 2.x transformers are inadequate to handle case-sensitive SVG attributes. sanitize parses documents as HTML instead of XML, which causes all SVG attribute names (e.g. viewBox) to be downcased. * SVG element list: https://www.w3.org/TR/SVG/eltindex.html * SVG attribute list: https://www.w3.org/TR/SVG/attindex.html Closes #14555
-
- 05 May, 2016 3 commits
-
-
Yorick Peterse authored
Previously this method would directly receive the output of tag_name(). This method could either return a String or nil. In the previous setup this would somehow magically work but because Rugged::TagCollection#[] doesn't accept nil values it started to fail. To work around this the elsif in change_access_check() assigns the result of tag_name() to a local and then _only_ calls protected_tag?() if the tag name is not nil. The extra parenthesis are put in place to ensure that things are parsed correctly, without these the code would be parsed as follows: elsif tag_ref = (tag_name(ref) && protected_tag(tag_ref)) During runtime this would basically resolve to: elsif tag_ref = (tag_name(ref) && protected_tag(nil)) This is because when you refer to the variable you're assigning _in_ the assignment Ruby returns nil instead of raising an error.
-
Yorick Peterse authored
This removes the need for retrieving the entire list of tags just to check if a specific one exists.
-
Douglas Barbosa Alexandre authored
Pull Request Review Comments are comments on a portion of the unified diff.
-
- 04 May, 2016 1 commit
-
-
Rémy Coutable authored
Use Rugged's TagCollection#create instead of gitlab-shell's Repository#add_tag for better performance Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 29 Apr, 2016 1 commit
-
-
Paco Guzman authored
- Parameter validation as ISO8601 format
-
- 28 Apr, 2016 2 commits
-
-
Zeger-Jan van de Weg authored
-
Stan Hu authored
Previously all remote IPs appeared at 127.0.0.1, which made Akismet not very useful. Using the ActionDispatch Remote IP (http://api.rubyonrails.org/classes/ActionDispatch/RemoteIp.html) should provide more reliable results. Closes #16629
-
- 27 Apr, 2016 2 commits
-
-
James Lopez authored
-
Stan Hu authored
These changes were pulled from GitLab EE to support configuring an alternative API URL than the default https://api.github.com. In addition, the `verify_ssl` flag allows users to disable SSL cert checking. One modification: add a default `args` option if it does not exist to avoid breaking existing configurations.
-
- 21 Apr, 2016 2 commits
-
-
Jacob Vosmaer authored
This makes the memory killer behave more like 'sidekiqctl stop'.
-
Jacob Schatz authored
This reverts commit 0f309794, reversing changes made to 1e596fef.
-
- 20 Apr, 2016 2 commits
-
-
Yorick Peterse authored
Merely setting the "action" tag will only result in the transaction itself containing a value for this tag. To ensure other metrics also contain this tag we must set the action using Transaction#action= instead.
-
Sebastian Klier authored
-
- 19 Apr, 2016 4 commits
-
-
Arinde Eniola authored
-
Yorick Peterse authored
This allows users to configure the number of points stored in a single UDP packet. This in turn can be used to reduce the number of UDP packets being sent at the cost of these packets being somewhat larger. The default setting is 1 point per packet so nothing changes for existing users.
-
Gabriel Mazetto authored
-
Gabriel Mazetto authored
Code is based on Project Webhooks, removing deprecations and without commits listing.
-
- 18 Apr, 2016 9 commits
-
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Alfredo Sumaran authored
-
Jacob Schatz authored
-
Douglas Barbosa Alexandre authored
With these changes we don’t lost the issue/pr references when importing them to GitLab.
-
Yorick Peterse authored
Fixes gitlab-org/gitlab-ce#15335
-
Yorick Peterse authored
By using Module#prepend we can define a Module containing all proxy methods. This removes the need for setting up crazy method alias chains and in turn prevents us from having to deal with all that madness (e.g. methods calling each other recursively). Fixes gitlab-org/gitlab-ce#15281
-
- 15 Apr, 2016 3 commits
-
-
Robert Schilling authored
-
Robert Schilling authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 14 Apr, 2016 3 commits
-
-
Stan Hu authored
-
Stan Hu authored
Closes #14370 Move gon function into its own helper
-
James Lopez authored
-
- 13 Apr, 2016 1 commit
-
-
Valery Sizov authored
-