BigW Consortium Gitlab

  1. 10 Apr, 2017 1 commit
  2. 25 Jan, 2017 1 commit
  3. 20 Dec, 2016 1 commit
  4. 16 Dec, 2016 3 commits
    • Implement final review comments from @rymai. · e394d287
      Timothy Andrew authored
      - `raise "string"` raises a `RuntimeError` - no need to be explicit
      - Remove top-level comment in the `RevList` class
      - Use `%w()` instead of `%w[]`
      - Extract an `environment_variables` method to cache `env.slice(*ALLOWED_VARIABLES)`
      - Use `start_with?` for env variable validation instead of regex match
      - Validation specs for each allowed environment variable were identical. Build them dynamically.
      - Minor change to `popen3` expectation.
    • Implement review comments from @dbalexandre. · 3e144276
      Timothy Andrew authored
      - Don't define "allowed environment variables" in two places.
      - Dispatch to different arities of `Popen.open` without an if/else block.
      - Use `described_class` instead of explicitly stating the class name within a
      - spec.
      - Remove `git_environment_variables_validator_spec` and keep the validation inline.
    • Validate environment variables in `Gitlab::Git::RevList` · a2b39feb
      Timothy Andrew authored
      The list of environment variables in `Gitlab::Git::RevList` need to be validate
      to make sure that they don't reference any other project on disk.
      
      This commit mixes in `ActiveModel::Validations` into `Gitlab::Git::RevList`, and
      validates that the environment variables are on the level (using a custom
      validator class). If the validations fail, the force push is still executed
      without any environment variables set.
      
      Add specs for the validation using shared examples.