- 17 Feb, 2017 1 commit
-
-
Douwe Maan authored
-
- 26 Jan, 2017 2 commits
-
- 06 Jan, 2017 5 commits
-
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
- 05 Jan, 2017 3 commits
-
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
Removing those weird setup in assign_change_commit_vars fixed all the failures in the tests. I still cannot say why but clearly we need to have better names. It's so confusing right now. We should seriously stop fiddling those instance variables.
-
Lin Jen-Shin authored
This is seriously confusing but a target branch in merge request, is actually the source branch for GitOperationService, which is the base branch. The source branch in a merge request, is the target branch for GitOperationService, which is where we want to make commits. Perhaps we should rename source branch in GitOperationService to base branch, and target branch to committing branch.
-
- 04 Jan, 2017 2 commits
-
-
Lin Jen-Shin authored
- 29 Dec, 2016 1 commit
-
-
Felipe Artur authored
-
- 13 Dec, 2016 2 commits
-
-
Lin Jen-Shin authored
-
- 09 Dec, 2016 1 commit
-
-
Douwe Maan authored
Replace MR access checks with use of MergeRequestsFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867
- Potentially untested - No test coverage - Test coverage of some sort exists (a test failed when error raised) - Test coverage of return value (a test failed when nil used) - Permissions check tested - [x] app/finders/notes_finder.rb:17 - [x] app/views/layouts/nav/_project.html.haml:80 [`.count`] - [x] app/controllers/concerns/creates_commit.rb:84 - [x] app/controllers/projects/commits_controller.rb:24 - [x] app/controllers/projects/compare_controller.rb:56 - [x] app/controllers/projects/discussions_controller.rb:29 - [x] app/controllers/projects/todos_controller.rb:27 - [x] app/models/commit.rb:268 - [x] lib/gitlab/search_results.rb:71 - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)` - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`. - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use of unchecked `merged_merge_request?` See merge request !2033
-
- 08 Dec, 2016 2 commits
-
-
Lin Jen-Shin authored
We shouldn't pass a non-existing branch to source_branch. Checkout test for: * spec/features/tags/master_views_tags_spec.rb:24 * spec/features/projects/files/project_owner_sees_link_to_create_license_file_in_empty_project_spec.rb:13
-
Lin Jen-Shin authored
-
- 15 Nov, 2016 2 commits
-
-
Lin Jen-Shin authored
- 14 Nov, 2016 1 commit
-
-
Lin Jen-Shin authored
-
- 10 Sep, 2016 1 commit
-
-
tiagonbotelho authored
refactors update file
-
- 12 Jul, 2016 13 commits
-
-
tiagonbotelho authored
-
tiagonbotelho authored
changes the usasge of path to file_path on blob_controller for compatibillity with the create action
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-
- 11 Jul, 2016 1 commit
-
-
tiagonbotelho authored
changes the usasge of path to file_path on blob_controller for compatibillity with the create action
-
- 08 Jul, 2016 3 commits
-
-
tiagonbotelho authored
-
tiagonbotelho authored
-
tiagonbotelho authored
-