- 12 Oct, 2016 1 commit
-
-
James Lopez authored
Also, updated specs and docs.
-
- 20 Sep, 2016 3 commits
-
-
Timothy Andrew authored
- Don't use `TableReferences` - using `.arel_table` is shorter! - Move some database-related code to `Gitlab::Database` - Remove the `MergeRequest#issues_closed` and `Issue#closed_by_merge_requests` associations. They were either shadowing or were too similar to existing methods. They are not being used anywhere, so it's better to remove them to reduce confusion. - Use Rails 3-style validations - Index for `MergeRequest::Metrics#first_deployed_to_production_at` - Only include `CycleAnalyticsHelpers::TestGeneration` for specs that need it. - Other minor refactorings.
-
Timothy Andrew authored
And `scss_lint`
-
Timothy Andrew authored
A number of failures were introduced due to performance improvements (like pre-calculating metrics).
-
- 07 Sep, 2016 3 commits
-
-
Timothy Andrew authored
1. Move the test generation to `CycleAnalyticsHelpers::TestGeneration` 2. Move all helper methods (previously placed in each individual spec file) to `CycleAnalyticsHelpers`
-
Timothy Andrew authored
- Tests would randomly fail because of naming conflicts. - Use a `random_git_name` method instead of using `FFaker` directly.
-
Timothy Andrew authored
- Move the "data belongs to other project" test case into the generated tests, and remove the explicit tests from the `code` and `plan` phases.
-
- 02 Sep, 2016 2 commits
-
-
Timothy Andrew authored
1. Generalise the specs that will be common across all cycle analytics phases. 2. Rewrite specs `issue` and `plan` to use this abstracted testing strategy. 3. Specs that are specific to a given phase, or unwieldy to test in an abstracted manner, are added to each phase's spec.
-
Timothy Andrew authored
Clean up the `issue` tests as well
-