- 15 Aug, 2016 1 commit
-
-
Lin Jen-Shin authored
-
- 12 Aug, 2016 1 commit
-
-
Paco Guzman authored
-
- 11 Aug, 2016 7 commits
-
-
Stan Hu authored
There is a race condition in DestroyGroupService now that projects are deleted asynchronously: 1. User attempts to delete group 2. DestroyGroupService iterates through all projects and schedules a Sidekiq job to delete each Project 3. DestroyGroupService destroys the Group, leaving all its projects without a namespace 4. Projects::DestroyService runs later but the can?(current_user, :remove_project) is `false` because the user no longer has permission to destroy projects with no namespace. 5. This leaves the project in pending_delete state with no namespace/group. Projects without a namespace or group also adds another problem: it's not possible to destroy the container registry tags, since container_registry_path_with_namespace is the wrong value. The fix is to destroy the group asynchronously and to run execute directly on Projects::DestroyService. Closes #17893
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
Scott Le authored
DRY code + fix rubocop Add more test cases Append to changelog DRY changes list find_url service for merge_requests use GET for getting merge request links remove files rename to get_url_service reduce loop add test case for cross project refactor tiny thing update changelog
-
Kamil Trzcinski authored
This change simplifies a Pipeline processing by introducing a special new status: created. This status is used for all builds that are created for a pipeline. We are then processing next stages and queueing some of the builds (created -> pending) or skipping them (created -> skipped). This makes it possible to simplify and solve a few ordering problems with how previously builds were scheduled. This also allows us to visualise a full pipeline (with created builds). This also removes an after_touch used for updating a pipeline state parameters. Right now in various places we explicitly call a reload_status! on pipeline to force it to be updated and saved.
-
Lin Jen-Shin authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 10 Aug, 2016 2 commits
-
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
Also, mutualize AccessRequests and Members endpoints for Group & Project. New API documentation for the AccessRequests endpoints. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 09 Aug, 2016 2 commits
-
-
Connor Shea authored
-
tiagonbotelho authored
-
- 05 Aug, 2016 1 commit
-
-
Z.J. van de Weg authored
-
- 04 Aug, 2016 1 commit
-
-
Z.J. van de Weg authored
Also, fix the failing test in the process
-
- 03 Aug, 2016 3 commits
-
-
Z.J. van de Weg authored
Also a minor clean up of the post endpoint
-
Z.J. van de Weg authored
Resolves #20123
-
Paco Guzman authored
So we have raw_diffs too
-
- 01 Aug, 2016 1 commit
-
-
Z.J. van de Weg authored
-
- 29 Jul, 2016 4 commits
-
-
Z.J. van de Weg authored
Also a couple of minor edits for this branch are included
-
Z.J. van de Weg authored
-
Z.J. van de Weg authored
-
Timothy Andrew authored
1. The new data model moves from `developers_can_{push,merge}` to `allowed_to_{push,merge}`. 2. The API interface has not been changed. It still accepts `developers_can_push` and `developers_can_merge` as options. These attributes are inferred from the new data model. 3. Modify the protected branch create/update services to translate from the API interface to our current data model.
-
- 28 Jul, 2016 1 commit
-
-
dixpac authored
-
- 26 Jul, 2016 1 commit
-
-
Patricio Cano authored
-
- 21 Jul, 2016 1 commit
-
-
Lin Jen-Shin authored
-
- 20 Jul, 2016 14 commits
-
-
Alejandro Rodríguez authored
Also, in favour of consistency, deprecate `/projects/:id/keys/...` routes in favour of `/projects/:id/deploy_keys/...`
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
-
Lin Jen-Shin authored
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13195683 and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13195692 another_artifacts was no longer used and then there's no point to put let in outer scope anymore.
-
Lin Jen-Shin authored
this should properly test that it's really getting the builds from the latest successful pipelines and latest successful builds.
-
Lin Jen-Shin authored
also added a test for checking this.
-
Lin Jen-Shin authored
rubocop was complaining
-