- 28 Apr, 2017 3 commits
-
-
Robert Speicher authored
-
Robert Speicher authored
We're going to add another cop that deals with another aspect of `add_column_with_default`, so we need to separate them.
-
Robert Speicher authored
-
- 05 Apr, 2017 1 commit
-
-
blackst0ne authored
-
- 07 Mar, 2017 1 commit
-
-
Douwe Maan authored
-
- 01 Mar, 2017 2 commits
-
-
Sean McGivern authored
-
Sean McGivern authored
From the Ruby style guide: # bad class FooError < StandardError end # okish class FooError < StandardError; end # good FooError = Class.new(StandardError) This cop does that, but only for error classes (classes where the superclass ends in 'Error'). We have empty controllers and models, which are perfectly valid empty classes.
-
- 23 Feb, 2017 5 commits
-
-
Douwe Maan authored
This reverts commit e00fb2bdc2090e9cabeb1eb35a2672a882cc96e9. # Conflicts: # .rubocop.yml # .rubocop_todo.yml # lib/gitlab/ci/config/entry/global.rb # lib/gitlab/ci/config/entry/jobs.rb # spec/lib/gitlab/ci/config/entry/factory_spec.rb # spec/lib/gitlab/ci/config/entry/global_spec.rb # spec/lib/gitlab/ci/config/entry/job_spec.rb # spec/lib/gitlab/ci/status/build/factory_spec.rb # spec/lib/gitlab/incoming_email_spec.rb
-
Douwe Maan authored
This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
-
Douwe Maan authored
-
Douwe Maan authored
-
Douwe Maan authored
-
- 10 Feb, 2017 1 commit
-
-
Yorick Peterse authored
This adds a Rubocop rule to enforce the use of add_concurrent_foreign_key instead of the regular add_foreign_key method. This cop has been disabled for existing migrations so we don't need to change those.
-
- 09 Feb, 2017 1 commit
-
-
Robert Speicher authored
-
- 08 Feb, 2017 2 commits
-
-
Douwe Maan authored
-
Douwe Maan authored
-
- 31 Jan, 2017 1 commit
-
-
Adam Pahlevi authored
code fix for aesthetic & conventions remove unused proc
-
- 29 Jun, 2016 1 commit
-
-
Yorick Peterse authored
There are currently two cops for this: * Migration/AddIndex: checks if indexes are added concurrently * Migration/ColumnWithDefault: checks if columns with default values are added in a concurrent manner Both cops are fairly simple and make no attempt at correcting the code as this is quite hard to do (e.g. modifications may need to be applied in various places in the same file). They however should provide enough to catch people ignoring the comments in generated migrations telling them to use add_concurrent_index or add_column_with_default.
-