- 06 Jul, 2017 4 commits
-
-
Timothy Andrew authored
- Change double quotes to single quotes. - Why is `OmniAuth.config.full_host` being reassigned in the integration test? - Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task - Other minor changes
-
Timothy Andrew authored
-
Timothy Andrew authored
- There was previously a test for `saml` login in `login_spec`, but this didn't seem to be passing. A lot of things didn't seem right here, and I suspect that this test hasn't been running. I'll investigate this further. - It took almost a whole working day to figure out this line: OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') } As always, it's obvious in retrospect, but it took some digging to figure out tests were failing and returning 404s during the callback phase. - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
-
Timothy Andrew authored
- Pass a `remember_me` query parameter along with the initial OAuth request, and pick this parameter up during the omniauth callback from request.env['omniauth.params']`. - For 2FA-based login, copy the `remember_me` param from `omniauth.params` to `params`, which the 2FA process will pick up. - For non-2FA-based login, simply call the `remember_me` devise method to set the session cookie.
-
- 05 Jul, 2017 1 commit
-
-
Sean McGivern authored
This reverts merge request !11963
-
- 03 Jul, 2017 5 commits
-
-
Timothy Andrew authored
- Change double quotes to single quotes. - Why is `OmniAuth.config.full_host` being reassigned in the integration test? - Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task - Other minor changes
-
Timothy Andrew authored
-
Timothy Andrew authored
- There was previously a test for `saml` login in `login_spec`, but this didn't seem to be passing. A lot of things didn't seem right here, and I suspect that this test hasn't been running. I'll investigate this further. - It took almost a whole working day to figure out this line: OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') } As always, it's obvious in retrospect, but it took some digging to figure out tests were failing and returning 404s during the callback phase. - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
-
Timothy Andrew authored
- Pass a `remember_me` query parameter along with the initial OAuth request, and pick this parameter up during the omniauth callback from request.env['omniauth.params']` - For 2FA-based login, copy the `remember_me` param from `omniauth.params` to `params`, which the 2FA process will pick up. - For non-2FA-based login, simply call the `remember_me` devise method to set the session cookie.
-
Simon Knox authored
-
- 24 May, 2017 3 commits
-
-
Douwe Maan authored
This reverts commit b0498c17
-
Douwe Maan authored
-
Douwe Maan authored
-
- 09 Mar, 2017 1 commit
-
-
tauriedavis authored
-
- 23 Feb, 2017 1 commit
-
-
Douwe Maan authored
-
- 15 Feb, 2017 1 commit
-
-
Semyon Pupkov authored
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/24036
-
- 07 Feb, 2017 1 commit
-
-
Jarka Kadlecova authored
-
- 02 Feb, 2017 1 commit
-
-
Bryce Johnson authored
-
- 12 Jan, 2017 1 commit
-
-
Felipe Artur authored
-
- 04 Jan, 2017 1 commit
-
-
Robert Speicher authored
-
- 03 Jan, 2017 1 commit
-
-
Drew Blessing authored
It's too easy to mistype an email or password when signing up. The support team is receiving an increasing number of requests because users mistype their email. We can eliminate this problem by requiring users to confirm the email before registering. The same issue can occur for the password field so we should add this, too. We should note that password confirmation is part of the default Devise forms. I don't know why/when GitLab removed it.
-
- 31 Dec, 2016 3 commits
-
-
Kushal Pandya authored
-
Kushal Pandya authored
-
Kushal Pandya authored
-
- 18 Nov, 2016 1 commit
-
-
Timothy Andrew authored
Javascript does not support the negative lookbehind assertion (?<!) used in the Ruby regex (to disallow usernames ending in `.git` or `.atom`. Getting the client side code to fully support this format is non-trivial, since we'd either have to heavily complicate the regex used, or modify the frontend code to support more complex validation schemes (it currently uses HTML5 validations). The pragmatic choice is to create a `Gitlab::Regex::NAMESPACE_REGEX_STR_SIMPLE` regex to serve as a Javascript-compatible version of `NAMESPACE_REGEX_STR`. The client-side code will not display an error for usernames ending in `.git` and `.atom`, but these will be caught by the server-side validation.
-
- 10 Nov, 2016 1 commit
-
-
Luc Didry authored
This commit is dedicated to GuilhemB, thanks for supporting me on Tipeee :-)
-
- 02 Nov, 2016 1 commit
-
-
Bryce Johnson authored
-
- 01 Nov, 2016 1 commit
-
-
Bryce Johnson authored
-
- 24 Oct, 2016 1 commit
-
-
Bryce Johnson authored
-
- 20 Oct, 2016 1 commit
-
-
Bryce Johnson authored
(Also fix some issues for session views on small screens.)
-
- 18 Oct, 2016 4 commits
-
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
- 16 Oct, 2016 1 commit
-
-
Stan Hu authored
-
- 15 Oct, 2016 5 commits
-
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-