+ address small nitpicks

* master: (242 commits)
  Validate user namespace before saving so that errors persist on model
  Reset Project's column information in spec/lib/gitlab/background_migration/populate_merge_request_metrics_with_events_data_spec.rb
  Explicitly set cwd in Sidekiq memory killer instead of depending on getcwd
  Downgrade google-protobuf
  Close low level rugged repository in project cache worker
  File upload UI obeys LFS filters
  Resolve "Add a link to documentation on how to get external ip in the Kubernetes cluster details page"
  Upgrade GitLab Workhorse to v3.6.0
  Add sorting options for /users API (admin only)
  improvements from feedback
  [ci-skip] add changelog
  remove file after `Upload#destroy`
  Fix a hardcoded pipeline ID in a spinach step
  Override group sidebar links
  Replace "cluster" with "Kubernetes cluster"
  Reorder async/sync tasks in BuildFinishedWorker to read traces efficiently
  Fix tests for Drop filename enforcement
  Revert using expand_fixture_path in factory
  Revert "Add FixtureHelpers for FactoryGirl"
  Refactor :trace to :trace_live in spec
  ...

Validate user namespace before saving so that errors persist on model

Closes #42140

See merge request gitlab-org/gitlab-ce!16902

Explicitly set cwd in Sidekiq memory killer instead of depending on getcwd

See merge request gitlab-org/gitlab-ce!16954

Resolve "spec/ee/spec/services/ee/projects/destroy_service_spec.rb is failing"

See merge request gitlab-org/gitlab-ce!16955

Reset Project's column information in spec/lib/gitlab/background_migration/populate_merge_request_metrics_with_events_data_spec.rb
Signed-off-by: Rémy Coutable <remy@rymai.me>

Resolve "ProjectCacheWorker leaks file descriptors"

Closes #42730

See merge request gitlab-org/gitlab-ce!16930

Refactor Gitlab::Git code related to LFS changes for Gitaly migration

Closes gitaly#980

See merge request gitlab-org/gitlab-ce!16835

Downgrade google-protobuf

See merge request gitlab-org/gitlab-ce!16941

Add sorting options for /users API

Closes #42669

See merge request gitlab-org/gitlab-ce!16945

Signed-off-by: Bastian Blank <waldi@debian.org>

File upload UI obeys LFS filter

Closes #29876

See merge request gitlab-org/gitlab-ce!16412

# Conflicts:
#   Gemfile
#   Gemfile.lock

Replace "cluster" with "Kubernetes cluster"

Closes #41963

See merge request gitlab-org/gitlab-ce!16778

Upgrade GitLab Workhorse to v3.6.0

See merge request gitlab-org/gitlab-ce!16946

Uses Lfs::FileModificationHandler to coordinate LFS detection, creation of LfsObject, etc

Caveats:
 1. This isn't used by the multi-file editor / Web IDE
 2. This isn't used on rename. We'd need to be able to download LFS files
    and add them to the commit if they no longer match so not as simple.
 3. We only check the root .gitattributes file, so this should be improved
    to correctly check for nested .gitattributes files in subfolders.

Uploads should delete files when destroyed

Closes #14256

See merge request gitlab-org/gitlab-ce!16799

Merge branch '42693-add-a-link-to-documentation-on-how-to-get-external-ip-in-the-kubernetes-cluster-details-page' into 'master'

Resolve "Add a link to documentation on how to get external ip in the Kubernetes cluster details page"

Closes #42693

See merge request gitlab-org/gitlab-ce!16937

Resolve "Add a link to documentation on how to get external ip in the Kubernetes cluster details page"

CE: Trace as artifacts (FileStorage only)

Closes gitlab-ee#4180

See merge request gitlab-org/gitlab-ce!16702

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

it will also automatically prune empty directories for
`FileUploader`-based uploaders.

Override group sidebar links

See merge request gitlab-org/gitlab-ce!16942

Resolve "features/project/commits/commits.feature is failing on master"

Closes #42798

See merge request gitlab-org/gitlab-ce!16940