- 20 Oct, 2017 1 commit
-
-
Jacopo authored
-
- 10 Aug, 2017 1 commit
-
-
Yorick Peterse authored
This commit migrates events data in such a way that push events are stored much more efficiently. This is done by creating a shadow table called "events_for_migration", and a table called "push_event_payloads" which is used for storing push data of push events. The background migration in this commit will copy events from the "events" table into the "events_for_migration" table, push events in will also have a row created in "push_event_payloads". This approach allows us to reclaim space in the next release by simply swapping the "events" and "events_for_migration" tables, then dropping the old events (now "events_for_migration") table. The new table structure is also optimised for storage space, and does not include the unused "title" column nor the "data" column (since this data is moved to "push_event_payloads"). == Newly Created Events Newly created events are inserted into both "events" and "events_for_migration", both using the exact same primary key value. The table "push_event_payloads" in turn has a foreign key to the _shadow_ table. This removes the need for recreating and validating the foreign key after swapping the tables. Since the shadow table also has a foreign key to "projects.id" we also don't have to worry about orphaned rows. This approach however does require some additional storage as we're duplicating a portion of the events data for at least 1 release. The exact amount is hard to estimate, but for GitLab.com this is expected to be between 10 and 20 GB at most. The background migration in this commit deliberately does _not_ update the "events" table as doing so would put a lot of pressure on PostgreSQL's auto vacuuming system. == Supporting Both Old And New Events Application code has also been adjusted to support push events using both the old and new data formats. This is done by creating a PushEvent class which extends the regular Event class. Using Rails' Single Table Inheritance system we can ensure the right class is used for the right data, which in this case is based on the value of `events.action`. To support displaying old and new data at the same time the PushEvent class re-defines a few methods of the Event class, falling back to their original implementations for push events in the old format. Once all existing events have been migrated the various push event related methods can be removed from the Event model, and the calls to `super` can be removed from the methods in the PushEvent model. The UI and event atom feed have also been slightly changed to better handle this new setup, fortunately only a few changes were necessary to make this work. == API Changes The API only displays push data of events in the new format. Supporting both formats in the API is a bit more difficult compared to the UI. Since the old push data was not really well documented (apart from one example that used an incorrect "action" nmae) I decided that supporting both was not worth the effort, especially since events will be migrated in a few days _and_ new events are created in the correct format.
-
- 02 Aug, 2017 1 commit
-
-
Robert Speicher authored
-
- 19 Jul, 2017 1 commit
-
-
Mike Greiling authored
-
- 14 Jun, 2017 1 commit
-
-
Robert Speicher authored
-
- 18 May, 2017 1 commit
-
-
Michael Kozono authored
Don’t replace a substring of the path if it is part of the top level route. E.g. When redirecting from `/groups/ups` to `/groups/foo`, be careful not to do `/grofoo/ups`. Projects are unaffected by this issue, but I am grouping the `#ensure_canonical_path` tests similar to the group and user tests.
-
- 11 May, 2017 1 commit
-
-
Michael Kozono authored
-
- 05 May, 2017 5 commits
-
-
Michael Kozono authored
-
Michael Kozono authored
Note: This changes the behavior of user lookups (see the spec change) so it acts the same way as groups and projects. Unauthenticated clients attempting to access a user page will be redirected to login whether the user exists and is publicly restricted, or does not exist at all.
-
Michael Kozono authored
-
Michael Kozono authored
-
Michael Kozono authored
-
- 25 Jan, 2017 1 commit
-
-
Robert Speicher authored
-
- 27 Sep, 2016 1 commit
-
-
Nick Thomas authored
Projects::ForkService delegates to this service almost entirely, but needed one small change so it would propagate create errors correctly. CreateService#execute needs significant refactoring; it is now right at the complexity limit set by Rubocop. I avoided doing so in this commit to keep the diff as small as possible. Several tests depend on the insecure behaviour of ForkService, so fi them up at the same time.
-
- 01 Jul, 2016 1 commit
-
-
Grzegorz Bizon authored
-
- 27 Jun, 2016 1 commit
-
-
Z.J. van de Weg authored
-
- 03 Jun, 2016 2 commits
-
-
James Lopez authored
This reverts commit 3e991230.
-
James Lopez authored
# Conflicts: # app/models/project.rb
-
- 08 May, 2016 1 commit
-
-
Long Nguyen authored
-
- 18 Apr, 2016 5 commits
-
-
Felipe Artur authored
-
Felipe Artur authored
-
Felipe Artur authored
-
Felipe Artur authored
-
Felipe Artur authored
-
- 22 Feb, 2016 1 commit
-
-
James Lopez authored
-
- 18 Nov, 2015 1 commit
-
-
Yorick Peterse authored
Previously this controller would in multiple places load tons (read: around 65000) project and/or group IDs into memory. These changes in combination with the previous commits significantly cut down loading times of user profile pages and the Atom feeds of users.
-
- 18 Jul, 2015 1 commit
-
-
Robert Speicher authored
Closes #2012
-
- 22 Mar, 2015 1 commit
-
-
Dmitriy Zaporozhets authored
-
- 18 Mar, 2015 1 commit
-
-
Hannes Rosenögger authored
-
- 29 Jan, 2015 3 commits
-
-
Dmitriy Zaporozhets authored
-
Dmitriy Zaporozhets authored
-
Hannes Rosenögger authored
-