BigW Consortium Gitlab

  1. 07 Dec, 2017 1 commit
  2. 06 Oct, 2017 1 commit
    • Create idea of read-only database · d1366971
      Toon Claes authored
      In GitLab EE, a GitLab instance can be read-only (e.g. when it's a Geo
      secondary node). But in GitLab CE it also might be useful to have the
      "read-only" idea around. So port it back to GitLab CE.
      
      Also having the principle of read-only in GitLab CE would hopefully
      lead to less errors introduced, doing write operations when there
      aren't allowed for read-only calls.
      
      Closes gitlab-org/gitlab-ce#37534.
  3. 05 Jun, 2017 3 commits
    • Refactor to let GitAccess errors bubble up · 23d37382
      Michael Kozono authored
      No external behavior change.
      
      This allows `GitHttpController` to set the HTTP status based on the type of error. Alternatively, we could have added an attribute to GitAccessStatus, but this pattern seemed appropriate.
    • Fix Git over HTTP spec · ff8a053d
      Michael Kozono authored
      * The spec has 7 failures at this point
      * Specify rendered error messages
      * Render the GitAccess message rather than “Access denied”
      * Render the Not Found message provided by GitAccess, instead of a custom one
      * Expect GitAccess to check the config for whether Git-over-HTTP pull or push is disabled, rather than doing it in the controller
      * Add more thorough testing for authentication
      * Dried up a lot of tests
      * Fixed some broken tests
  4. 06 Dec, 2016 1 commit
  5. 30 Nov, 2016 1 commit
  6. 11 Nov, 2016 1 commit
  7. 18 Jul, 2016 1 commit
  8. 13 Jul, 2016 2 commits
    • Revert "Merge branch '18193-developers-can-merge' into 'master' · 530f5158
      Robert Speicher authored
      This reverts commit 9ca633eb, reversing
      changes made to fb229bbf.
    • Refactor `Gitlab::GitAccess` · 60245bbe
      Timothy Andrew authored
      1. Don't use case statements for dispatch anymore. This leads to a lot
         of duplication, and makes the logic harder to follow.
      
      2. Remove duplicated logic.
      
          - For example, the `can_push_to_branch?` exists, but we also have a
            different way of checking the same condition within `change_access_check`.
      
          - This kind of duplication is removed, and the `can_push_to_branch?`
            method is used in both places.
      
      3. Move checks returning true/false to `UserAccess`.
      
          - All public methods in `GitAccess` now return an instance of
            `GitAccessStatus`. Previously, some methods would return
            true/false as well, which was confusing.
      
          - It makes sense for these kinds of checks to be at the level of a
            user, so the `UserAccess` class was repurposed for this. The prior
            `UserAccess.allowed?` classmethod is converted into an instance
            method.
      
          - All external uses of these checks have been migrated to use the
            `UserAccess` class
      
      4. Move the "change_access_check" into a separate class.
      
          - Create the `GitAccess::ChangeAccessCheck` class to run these
            checks, which are quite substantial.
      
          - `ChangeAccessCheck` returns an instance of `GitAccessStatus` as
            well.
      
      5. Break out the boolean logic in `ChangeAccessCheck` into `if/else`
         chains - this seems more readable.
      
      6. I can understand that this might look like overkill for !4892, but I
         think this is a good opportunity to clean it up.
      
          - http://martinfowler.com/bliki/OpportunisticRefactoring.html
  9. 26 Jun, 2015 1 commit
  10. 13 May, 2015 1 commit
  11. 24 Mar, 2015 1 commit
  12. 24 Nov, 2014 1 commit
  13. 18 Nov, 2014 1 commit
  14. 07 Oct, 2014 1 commit