- 18 May, 2016 1 commit
-
-
Felipe Artur authored
-
- 16 May, 2016 11 commits
-
-
Felipe Artur authored
-
Robert Speicher authored
Remove unused methods from Event model
-
Robert Speicher authored
-
Robert Speicher authored
-
Robert Speicher authored
-
Robert Speicher authored
Given an activity feed entry like: > Douwe Maan commented on [issue #123] at [gitlab-org/gitlab-ce] ...the `issue #123` link will now have a `title` attribute.
-
Felipe Artur authored
-
Felipe Artur authored
-
Felipe Artur authored
-
Sean McGivern authored
Postgres only needs to select a single column, so that can used as a sub-query where `Milestone.upcoming_ids_by_projects` is actually used in `IssuableFinder`. MySQL needs to select the `due_date` column because it's used in the `HAVING` clause, so it has to return an array of IDs.
-
Sean McGivern authored
Before: we took the next milestone due across all projects in the search and found issues whose milestone title matched that one. Problems: 1. The milestone could be closed. 2. Different projects have milestones with different schedules. 3. Different projects have milestones with different titles. 4. Different projects can have milestones with different schedules, but the _same_ title. That means we could show issues from a past milestone, or one that's far in the future. After: gather the ID of the next milestone on each project we're looking at, and find issues with those milestone IDs. Problems: 1. For a lot of projects, this can return a lot of IDs. 2. The SQL query has to be different between Postgres and MySQL, because MySQL is much more lenient with HAVING: as well as the columns appearing in GROUP BY or in aggregate clauses, MySQL allows them to appear in the SELECT list (un-aggregated).
-
- 14 May, 2016 2 commits
-
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
-
- 13 May, 2016 6 commits
-
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Douwe Maan authored
-
Douwe Maan authored
-
Artem Sidorenko authored
-
Gabriel Mazetto authored
-
- 12 May, 2016 7 commits
-
-
Ahmad Sherif authored
Closes #15638
-
Kamil Trzcinski authored
-
Andrei Gliga authored
-
Andrei Gliga authored
-
Andrei Gliga authored
-
Andrei Gliga authored
-
Andrei Gliga authored
-
- 11 May, 2016 3 commits
-
-
Grzegorz Bizon authored
-
Sean McGivern authored
-
Connor Shea authored
Also fixes the errors caused by enabling the cop. casecmp is more performant than `.downcase` and `==`.
-
- 10 May, 2016 7 commits
-
-
Sean McGivern authored
`User#starred_projects` doesn't perform any visibility checks. This has a couple of problems: 1. It assumes a user can always view all of their starred projects in perpetuity (project not changed to private, access revoked, etc.). 2. It assumes that we'll only ever allow a user to star a project they can view. This is currently the case, but bugs happen. Add `User#viewable_starred_projects` to filter the starred projects by those the user either has explicit access to, or are public or internal. Then use that in all places where we list the user's starred projects.
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
DJ Mountney authored
Also added a health check page to the admin section for resetting the token.
-
Grzegorz Bizon authored
-
Rémy Coutable authored
- Fix naming of API::CommitStatuses - Ensure we use require_dependency instead of require - Ensure the namespace is right in lib/api/api.rb, otherwise, we might require Grape::API::Helpers which defines the `#params` method. This is to avoid requiring a file multiple times and getting an "Already initialized constant" error. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Jacob Vosmaer authored
Robert Speicher and I believe this string gets sanitized further down the stack anyway. Doing this in a model class feels wrong.
-
Rémy Coutable authored
This reverts commit 4cc85a58, reversing changes made to 90ae445b. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
- 09 May, 2016 3 commits
-
-
Kamil Trzcinski authored
-
Kamil Trzcinski authored
We send a state of ansi2html to client, client needs to send this state back. The state describes the configuration of generator and position within trace.
-
Jeroen van Baarsen authored
In 8278b763 the default behaviour of annotation has changes, which was causing a lot of noise in diffs. We decided in #17382 that it is better to get rid of the whole annotate gem, and instead let people look at schema.rb for the columns in a table. Fixes: #17382
-