BigW Consortium Gitlab

  1. 21 Jun, 2017 2 commits
  2. 16 Jun, 2017 1 commit
    • Add table for files in merge request diffs · 9a73b634
      Sean McGivern authored
      This adds an ID-less table containing one row per file, per merge request
      diff. It has a column for each attribute on Gitlab::Git::Diff that is serialised
      currently, with the advantage that we can easily query the attributes of this
      new table.
      
      It does not migrate existing data, so we have fallback code when the legacy
      st_diffs column is present instead. For a merge request diff to be valid, it
      should have at most one of:
      
      * Rows in this new table, with the correct merge_request_diff_id.
      * A non-NULL st_diffs column.
      
      It may have neither, if the diff is empty.
  3. 15 Jun, 2017 1 commit
    • Add columns for custom notification settings · f4b5fcbc
      Sean McGivern authored
      Add columns for each custom notification level, defaulting to null. Read from
      those columns if non-null, otherwise fall back to the serialized column. Writing
      will write to the new column if `events` isn't manually set.
  4. 14 Jun, 2017 1 commit
  5. 13 Jun, 2017 1 commit
  6. 08 Jun, 2017 2 commits
    • Bring in security changes from the 9.2.5 release · 565ead61
      DJ Mountney authored
      Ran:
       - git format-patch v9.2.2..v9.2.5 --stdout > patchfile.patch
       - git checkout -b 9-2-5-security-patch origin/v9.2.2
       - git apply patchfile.patch
       - git commit
       - [Got the sha ref for the commit]
       - git checkout -b upstream-9-2-security master
       - git cherry-pick <SHA of the patchfile commit>
       - [Resolved conflicts]
       - git cherry-pick --continue
    • Bring in security changes from the 9.2.5 release · 1d1363e2
      DJ Mountney authored
      Ran:
       - git format-patch v9.2.2..v9.2.5 --stdout > patchfile.patch
       - git checkout -b 9-2-5-security-patch origin/v9.2.2
       - git apply patchfile.patch
       - git commit
       - [Got the sha ref for the commit]
       - git checkout -b upstream-9-2-security master
       - git cherry-pick <SHA of the patchfile commit>
       - [Resolved conflicts]
       - git cherry-pick --continue
  7. 07 Jun, 2017 1 commit
  8. 06 Jun, 2017 3 commits
  9. 02 Jun, 2017 3 commits
  10. 01 Jun, 2017 3 commits
  11. 31 May, 2017 3 commits
  12. 29 May, 2017 1 commit
  13. 26 May, 2017 2 commits
  14. 25 May, 2017 4 commits
  15. 24 May, 2017 4 commits
  16. 23 May, 2017 1 commit
  17. 17 May, 2017 4 commits
    • Check if OLD is set when migrating issue assignees · cb4ee4b1
      Yorick Peterse authored
      The procedure for migrating issue assignees is invoked on both an INSERT
      and UPDATE. This means it will fail for INSERTs because OLD is set to
      NULL in this case.
    • Index project_group_links.group_id · 91c971bf
      Yorick Peterse authored
      This column is used when refreshing authorizations and without the
      index leads to a sequence scan being performed on this table.
    • Convert nested groups to regular ones for MySQL · 53250d6d
      Yorick Peterse authored
      This migration will take all nested groups and convert them into regular
      groups, ensuring that members of any parent groups still have access to
      the child group. This migration relies on code external to it as copying
      all of this over involves hundreds of lines of code depending on all
      sorts of methods, making this practically impossible to do right.
    • Use CTEs for nested groups and authorizations · ac382b56
      Yorick Peterse authored
      This commit introduces the usage of Common Table Expressions (CTEs) to
      efficiently retrieve nested group hierarchies, without having to rely on
      the "routes" table (which is an _incredibly_ inefficient way of getting
      the data). This requires a patch to ActiveRecord (found in the added
      initializer) to work properly as ActiveRecord doesn't support WITH
      statements properly out of the box.
      
      Unfortunately MySQL provides no efficient way of getting nested groups.
      For example, the old routes setup could easily take 5-10 seconds
      depending on the amount of "routes" in a database. Providing vastly
      different logic for both MySQL and PostgreSQL will negatively impact the
      development process. Because of this the various nested groups related
      methods return empty relations when used in combination with MySQL.
      
      For project authorizations the logic is split up into two classes:
      
      * Gitlab::ProjectAuthorizations::WithNestedGroups
      * Gitlab::ProjectAuthorizations::WithoutNestedGroups
      
      Both classes get the fresh project authorizations (= as they should be
      in the "project_authorizations" table), including nested groups if
      PostgreSQL is used. The logic of these two classes is quite different
      apart from their public interface. This complicates development a bit,
      but unfortunately there is no way around this.
      
      This commit also introduces Gitlab::GroupHierarchy. This class can be
      used to get the ancestors and descendants of a base relation, or both by
      using a UNION. This in turn is used by methods such as:
      
      * Namespace#ancestors
      * Namespace#descendants
      * User#all_expanded_groups
      
      Again this class relies on CTEs and thus only works on PostgreSQL. The
      Namespace methods will return an empty relation when MySQL is used,
      while User#all_expanded_groups will return only the groups a user is a
      direct member of.
      
      Performance wise the impact is quite large. For example, on GitLab.com
      Namespace#descendants used to take around 580 ms to retrieve data for a
      particular user. Using CTEs we are able to reduce this down to roughly 1
      millisecond, returning the exact same data.
      
      == On The Fly Refreshing
      
      Refreshing of authorizations on the fly (= when
      users.authorized_projects_populated was not set) is removed with this
      commit. This simplifies the code, and ensures any queries used for
      authorizations are not mutated because they are executed in a Rails
      scope (e.g. Project.visible_to_user).
      
      This commit includes a migration to schedule refreshing authorizations
      for all users, ensuring all of them have their authorizations in place.
      Said migration schedules users in batches of 5000, with 5 minutes
      between every batch to smear the load around a bit.
      
      == Spec Changes
      
      This commit also introduces some changes to various specs. For example,
      some specs for ProjectTeam assumed that creating a personal project
      would _not_ lead to the owner having access, which is incorrect. Because
      we also no longer refresh authorizations on the fly for new users some
      code had to be added to the "empty_project" factory. This chunk of code
      ensures that the owner's permissions are refreshed after creating the
      project, something that is normally done in Projects::CreateService.
  18. 16 May, 2017 2 commits
  19. 15 May, 2017 1 commit