BigW Consortium Gitlab

  1. 22 Aug, 2017 1 commit
  2. 21 Aug, 2017 1 commit
  3. 10 Aug, 2017 2 commits
    • Use a specialized class for querying events · aac1de46
      Yorick Peterse authored
      This changes various controllers to use the new EventCollection class
      for retrieving events. This class uses a JOIN LATERAL query on
      PostgreSQL to retrieve queries in a more efficient way, while falling
      back to a simpler / less efficient query for MySQL.
      
      The EventCollection class also includes a limit on the number of events
      to display to prevent malicious users from cycling through all events,
      as doing so could put a lot of pressure on the database.
      
      JOIN LATERAL is only supported on PostgreSQL starting with version 9.3.0
      and as such this optimisation is only used when using PostgreSQL 9.3 or
      newer.
    • Migrate events into a new format · 0395c471
      Yorick Peterse authored
      This commit migrates events data in such a way that push events are
      stored much more efficiently. This is done by creating a shadow table
      called "events_for_migration", and a table called "push_event_payloads"
      which is used for storing push data of push events. The background
      migration in this commit will copy events from the "events" table into
      the "events_for_migration" table, push events in will also have a row
      created in "push_event_payloads".
      
      This approach allows us to reclaim space in the next release by simply
      swapping the "events" and "events_for_migration" tables, then dropping
      the old events (now "events_for_migration") table.
      
      The new table structure is also optimised for storage space, and does
      not include the unused "title" column nor the "data" column (since this
      data is moved to "push_event_payloads").
      
      == Newly Created Events
      
      Newly created events are inserted into both "events" and
      "events_for_migration", both using the exact same primary key value. The
      table "push_event_payloads" in turn has a foreign key to the _shadow_
      table. This removes the need for recreating and validating the foreign
      key after swapping the tables. Since the shadow table also has a foreign
      key to "projects.id" we also don't have to worry about orphaned rows.
      
      This approach however does require some additional storage as we're
      duplicating a portion of the events data for at least 1 release. The
      exact amount is hard to estimate, but for GitLab.com this is expected to
      be between 10 and 20 GB at most. The background migration in this commit
      deliberately does _not_ update the "events" table as doing so would put
      a lot of pressure on PostgreSQL's auto vacuuming system.
      
      == Supporting Both Old And New Events
      
      Application code has also been adjusted to support push events using
      both the old and new data formats. This is done by creating a PushEvent
      class which extends the regular Event class. Using Rails' Single Table
      Inheritance system we can ensure the right class is used for the right
      data, which in this case is based on the value of `events.action`. To
      support displaying old and new data at the same time the PushEvent class
      re-defines a few methods of the Event class, falling back to their
      original implementations for push events in the old format.
      
      Once all existing events have been migrated the various push event
      related methods can be removed from the Event model, and the calls to
      `super` can be removed from the methods in the PushEvent model.
      
      The UI and event atom feed have also been slightly changed to better
      handle this new setup, fortunately only a few changes were necessary to
      make this work.
      
      == API Changes
      
      The API only displays push data of events in the new format. Supporting
      both formats in the API is a bit more difficult compared to the UI.
      Since the old push data was not really well documented (apart from one
      example that used an incorrect "action" nmae) I decided that supporting
      both was not worth the effort, especially since events will be migrated
      in a few days _and_ new events are created in the correct format.
  4. 06 Jul, 2017 1 commit
  5. 21 Jun, 2017 1 commit
  6. 07 Jun, 2017 1 commit
  7. 06 Jun, 2017 1 commit
    • Introduce an Events API · ad3e180e
      Mark Fletcher authored
      * Meld the following disparate endpoints:
       * `/projects/:id/events`
       * `/events`
       * `/users/:id/events`
      + Add result filtering to the above endpoints:
       * action
       * target_type
       * before and after dates
  8. 31 May, 2017 1 commit
  9. 04 May, 2017 1 commit
  10. 26 Apr, 2017 1 commit
  11. 21 Mar, 2017 1 commit
  12. 24 Feb, 2017 1 commit
  13. 23 Feb, 2017 3 commits
  14. 13 Feb, 2017 4 commits
  15. 25 Nov, 2016 1 commit
  16. 23 Nov, 2016 1 commit
    • Remove event caching code · 5371da34
      Yorick Peterse authored
      Flushing the events cache worked by updating a recent number of rows in
      the "events" table. This has the result that on PostgreSQL a lot of dead
      tuples are produced on a regular basis. This in turn means that
      PostgreSQL will spend considerable amounts of time vacuuming this table.
      This in turn can lead to an increase of database load.
      
      For GitLab.com we measured the impact of not using events caching and
      found no measurable increase in response timings. Meanwhile not flushing
      the events cache lead to the "events" table having no more dead tuples
      as now rows are only inserted into this table.
      
      As a result of this we are hereby removing events caching as it does not
      appear to help and only increases database load.
      
      For more information see the following comment:
      https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6578#note_18864037
  17. 16 Nov, 2016 1 commit
  18. 09 Nov, 2016 1 commit
  19. 27 Oct, 2016 1 commit
  20. 20 Oct, 2016 2 commits
    • Differentiate the expire from leave event · f488b9f7
      Callum Dryden authored
      At the moment we cannot see weather a user left a project due to their
      membership expiring of if they themselves opted to leave the project.
      This adds a new event type that allows us to make this differentiation.
      Note that is not really feasable to go back and reliably fix up the
      previous events. As a result the events for previous expire removals
      will remain the same however events of this nature going forward will be
      correctly represented.
    • Differentiate the expire from leave event · 9124310f
      Callum Dryden authored
      At the moment we cannot see weather a user left a project due to their
      membership expiring of if they themselves opted to leave the project.
      This adds a new event type that allows us to make this differentiation.
      Note that is not really feasable to go back and reliably fix up the
      previous events. As a result the events for previous expire removals
      will remain the same however events of this nature going forward will be
      correctly represented.
  21. 11 Oct, 2016 1 commit
  22. 07 Oct, 2016 1 commit
    • Fix Event#reset_project_activity updates · 16626409
      Stan Hu authored
      !6678 removed the lease from Event#reset_project_activity, but it wasn't
      actually updating the project's last_activity_at timestamp properly.
      The WHERE clause would always return no matching projects. The spec
      passed occasionally because the created_at timestamp was automatically
      set to last_activity_at.
  23. 04 Oct, 2016 1 commit
    • Remove lease from Event#reset_project_activity · c9bcfc63
      Yorick Peterse authored
      Per GitLab.com's performance metrics this method could take up to 5
      seconds of wall time to complete, while only taking 1-2 milliseconds of
      CPU time. Removing the Redis lease in favour of conditional updates
      allows us to work around this.
      
      A slight drawback is that this allows for multiple threads/processes to
      try and update the same row. However, only a single thread/process will
      ever win since the UPDATE query uses a WHERE condition to only update
      rows that were not updated in the last hour.
      
      Fixes gitlab-org/gitlab-ce#22473
  24. 20 Sep, 2016 1 commit
  25. 19 Sep, 2016 1 commit
  26. 30 Aug, 2016 1 commit
  27. 06 Jul, 2016 1 commit
  28. 04 Jul, 2016 1 commit
  29. 28 Jun, 2016 1 commit
  30. 03 Jun, 2016 2 commits
  31. 16 May, 2016 2 commits