BigW Consortium Gitlab

Skip to content

G
gitlab-ce
Commit ff4d5fc1 by Adam Niedzielski
Options

Fix failures in default sort order spec

Test cases were not waiting for page load after clicking. This caused failures in test cases that were executed right after these incorrect ones, because of requests hitting server after a test was finished. We do not have to click links, we can go directly to a correct page by passing parameters in the URL.
parent c2173a14
Showing with 2 additions and 8 deletions
spec/features/issuables/default_sort_order_spec.rb
...@@ -180,16 +180,10 @@ describe 'Projects > Issuables > Default sort order', feature: true do ...@@ -180,16 +180,10 @@ describe 'Projects > Issuables > Default sort order', feature: true do
end end
def visit_merge_requests_with_state(project, state) def visit_merge_requests_with_state(project, state)
visit_merge_requests project visit_merge_requests project, state: state
visit_issuables_with_state state
end end
def visit_issues_with_state(project, state) def visit_issues_with_state(project, state)
visit_issues project visit_issues project, state: state
visit_issuables_with_state state
end
def visit_issuables_with_state(state)
within('.issues-state-filters') { find("span", text: state.titleize).click }
end end
end end
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment