Print notes number explained.

Printing just `[<number>]` was confusing - it looks like a ghost branch or something. Add `note` (or `notes`, depending on number of notes) to give some details of what this number means. Refactor code to follow DRY principle.

Print notes number explained.
fee5e17f · Vladislav Kaverin · Vladislav Kaverin · bce1c509 · fee5e17f · fee5e17f
Commit fee5e17f authored Aug 31, 2017 by Vladislav Kaverin Committed by Vladislav Kaverin Sep 08, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

graph_helper.rb app/helpers/graph_helper.rb +2 -1

bugfix-graph-friendly-notes-number.yml changelogs/unreleased/bugfix-graph-friendly-notes-number.yml +5 -0

No files found.
--- a/app/helpers/graph_helper.rb
+++ b/app/helpers/graph_helper.rb
@@ -7,7 +7,8 @@ module GraphHelper
    refs << commit_refs.join(' ')

    # append note count
-    refs << "[#{@graph.notes[commit.id]}]" if @graph.notes[commit.id] > 0
+    notes_count = @graph.notes[commit.id]
+    refs << "[#{notes_count} #{pluralize(notes_count, 'note')}]" if notes_count > 0

    refs
  end

--- a/changelogs/unreleased/bugfix-graph-friendly-notes-number.yml
+++ b/changelogs/unreleased/bugfix-graph-friendly-notes-number.yml
+---
+title: Show notes number more user-friendly in the graph
+merge_request: 13949
+author: Vladislav Kaverin
+type: changed