Ensure all refs are restored on a restore from backup

To restore all refs from a bundle, we need to use the --mirror option to ensure that all refs are properly restored. Without this, refs such as `refs/merge-requests/X` and `refs/keep-around/Y` would be omitted, which exposed a bug as described in https://gitlab.com/gitlab-org/gitlab-ce/issues/38319#note_41648608. Closes #38352

Ensure all refs are restored on a restore from backup
f3f304dc · Stan Hu · 171714c9 · f3f304dc · f3f304dc
Commit f3f304dc authored Sep 29, 2017 by Stan Hu
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

sh-restore-all-refs-backup.yml changelogs/unreleased/sh-restore-all-refs-backup.yml +5 -0

repository.rb lib/backup/repository.rb +1 -1

No files found.
--- a/changelogs/unreleased/sh-restore-all-refs-backup.yml
+++ b/changelogs/unreleased/sh-restore-all-refs-backup.yml
+---
+title: Ensure all refs are restored on a restore from backup
+merge_request:
+author:
+type: fixed
--- a/lib/backup/repository.rb
+++ b/lib/backup/repository.rb
@@ -78,7 +78,7 @@ module Backup
        project.ensure_storage_path_exists

        cmd = if File.exist?(path_to_project_bundle)
-                %W(#{Gitlab.config.git.bin_path} clone --bare #{path_to_project_bundle} #{path_to_project_repo})
+                %W(#{Gitlab.config.git.bin_path} clone --bare --mirror #{path_to_project_bundle} #{path_to_project_repo})
              else
                %W(#{Gitlab.config.git.bin_path} init --bare #{path_to_project_repo})
              end