Don't memoize storage configuration on `FsShardsCheck`

These values are already coming from memory, so we don't need to memoize. If we do memoize these, than the would not be stubbed when calling `stub_storage_settings` in specs

Don't memoize storage configuration on `FsShardsCheck`
eb63889f · Bob Van Landuyt · cfccb278 · eb63889f
Commit eb63889f authored Sep 21, 2017 by Bob Van Landuyt
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

fs_shards_check.rb lib/gitlab/health_checks/fs_shards_check.rb +2 -2

No files found.
--- a/lib/gitlab/health_checks/fs_shards_check.rb
+++ b/lib/gitlab/health_checks/fs_shards_check.rb
@@ -58,11 +58,11 @@ module Gitlab
        end

        def repository_storages
-          @repository_storage ||= storages_paths.keys
+          storages_paths.keys
        end

        def storages_paths
-          @storage_paths ||= Gitlab.config.repositories.storages
+          Gitlab.config.repositories.storages
        end

        def exec_with_timeout(cmd_args, *args, &block)