Speed up cached_pass? for composite rules

Both `Or` and `And` would evaluate whether each rule passed, then calculate a value based on the results of all of those. We can actually return early in many cases, without running the rule at all.

Speed up cached_pass? for composite rules
e9476eb9 · Sean McGivern · d7717192 · e9476eb9
Commit e9476eb9 authored Oct 04, 2017 by Sean McGivern
Hide whitespace changes
Inline Side-by-side

Showing with 12 additions and 8 deletions

rule.rb lib/declarative_policy/rule.rb +12 -8

No files found.
--- a/lib/declarative_policy/rule.rb
+++ b/lib/declarative_policy/rule.rb
@@ -206,11 +206,13 @@ module DeclarativePolicy
      end

      def cached_pass?(context)
-        passes = @rules.map { |r| r.cached_pass?(context) }
-        return false if passes.any? { |p| p == false }
-        return true if passes.all? { |p| p == true }
+        @rules.each do |rule|
+          pass = rule.cached_pass?(context)

-        nil
+          return pass if pass.nil? || pass == false
+        end
+
+        true
      end

      def repr
@@ -245,11 +247,13 @@ module DeclarativePolicy
      end

      def cached_pass?(context)
-        passes = @rules.map { |r| r.cached_pass?(context) }
-        return true if passes.any? { |p| p == true }
-        return false if passes.all? { |p| p == false }
+        @rules.each do |rule|
+          pass = rule.cached_pass?(context)

-        nil
+          return pass if pass.nil? || pass == true
+        end
+
+        false
      end

      def score(context)