BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
e02f1271
Unverified
Commit
e02f1271
authored
Apr 17, 2018
by
Zeger-Jan van de Weg
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Return nil on empty path
The execution path wasn't clear from the error, but either way this is a fix. Closes gitlab-org/gitaly#1115
parent
25cb70ba
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
0 deletions
+7
-0
commit.rb
lib/gitlab/git/commit.rb
+2
-0
commit_spec.rb
spec/models/commit_spec.rb
+5
-0
No files found.
lib/gitlab/git/commit.rb
View file @
e02f1271
...
...
@@ -486,6 +486,8 @@ module Gitlab
end
def
tree_entry
(
path
)
return
unless
path
.
present?
@repository
.
gitaly_migrate
(
:commit_tree_entry
)
do
|
is_migrated
|
if
is_migrated
gitaly_tree_entry
(
path
)
...
...
spec/models/commit_spec.rb
View file @
e02f1271
...
...
@@ -450,6 +450,11 @@ eos
it
"returns nil if the path doesn't exists"
do
expect
(
commit
.
uri_type
(
'this/path/doesnt/exist'
)).
to
be_nil
end
it
'is nil if the path is nil or empty'
do
expect
(
commit
.
uri_type
(
nil
)).
to
be_nil
expect
(
commit
.
uri_type
(
""
)).
to
be_nil
end
end
context
'when Gitaly commit_tree_entry feature is enabled'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment