BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
dfc2fe77
Commit
dfc2fe77
authored
Sep 22, 2016
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Merge branch…
Revert "Merge branch '22421-fix-issuable-counter-when-more-than-one-label-is-selected' into 'master'" This reverts commit
8ed5be59
, reversing changes made to
fb0d1378
.
parent
2450625b
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
26 deletions
+9
-26
application_helper.rb
app/helpers/application_helper.rb
+2
-13
filter_by_labels_spec.rb
spec/features/issues/filter_by_labels_spec.rb
+7
-13
No files found.
app/helpers/application_helper.rb
View file @
dfc2fe77
...
...
@@ -286,19 +286,8 @@ module ApplicationHelper
}
state_title
=
titles
[
state
]
||
state
.
to_s
.
humanize
records_with_state
=
records
.
public_send
(
state
)
# When filtering by multiple labels, the result of query.count is a Hash
# of the form { issuable_id1 => N, issuable_id2 => N }, where N is the
# number of labels selected. The ugly "trick" is to load the issuables
# as an array and get the size of the array...
# We should probably try to solve this properly in the future.
# See https://gitlab.com/gitlab-org/gitlab-ce/issues/22414
label_names
=
Array
(
params
.
fetch
(
:label_name
,
[]))
records_with_state
=
records_with_state
.
to_a
if
label_names
.
many?
count
=
records_with_state
.
size
html
=
content_tag
:span
,
state_title
count
=
records
.
public_send
(
state
).
size
html
=
content_tag
:span
,
state_title
if
count
.
present?
html
+=
" "
...
...
spec/features/issues/filter_by_labels_spec.rb
View file @
dfc2fe77
...
...
@@ -6,19 +6,20 @@ feature 'Issue filtering by Labels', feature: true do
let
(
:project
)
{
create
(
:project
,
:public
)
}
let!
(
:user
)
{
create
(
:user
)}
let!
(
:label
)
{
create
(
:label
,
project:
project
)
}
let
(
:bug
)
{
create
(
:label
,
project:
project
,
title:
'bug'
)
}
let
(
:feature
)
{
create
(
:label
,
project:
project
,
title:
'feature'
)
}
let
(
:enhancement
)
{
create
(
:label
,
project:
project
,
title:
'enhancement'
)
}
let
(
:issue1
)
{
create
(
:issue
,
title:
"Bugfix1"
,
project:
project
)
}
let
(
:issue2
)
{
create
(
:issue
,
title:
"Bugfix2"
,
project:
project
)
}
let
(
:issue3
)
{
create
(
:issue
,
title:
"Feature1"
,
project:
project
)
}
before
do
bug
=
create
(
:label
,
project:
project
,
title:
'bug'
)
feature
=
create
(
:label
,
project:
project
,
title:
'feature'
)
enhancement
=
create
(
:label
,
project:
project
,
title:
'enhancement'
)
issue1
=
create
(
:issue
,
title:
"Bugfix1"
,
project:
project
)
issue1
.
labels
<<
bug
issue2
=
create
(
:issue
,
title:
"Bugfix2"
,
project:
project
)
issue2
.
labels
<<
bug
issue2
.
labels
<<
enhancement
issue3
=
create
(
:issue
,
title:
"Feature1"
,
project:
project
)
issue3
.
labels
<<
feature
project
.
team
<<
[
user
,
:master
]
...
...
@@ -158,13 +159,6 @@ feature 'Issue filtering by Labels', feature: true do
wait_for_ajax
end
it
'shows a correct "Open" counter'
do
page
.
within
'.issues-state-filters'
do
expect
(
page
).
not_to
have_content
"{
#{
issue2
.
id
}
=> 1}"
expect
(
page
).
to
have_content
"Open 1"
end
end
it
'shows issue "Bugfix2" in issues list'
do
expect
(
page
).
to
have_content
"Bugfix2"
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment