BigW Consortium Gitlab

Fix boolean prop being provided as string

parent 34760245
...@@ -30,8 +30,12 @@ ...@@ -30,8 +30,12 @@
shouldRenderContent() { shouldRenderContent() {
return !this.isLoading && Object.keys(this.job).length; return !this.isLoading && Object.keys(this.job).length;
}, },
/**
* When job has not started the key will be `false`
* When job started the key will be a string with a date.
*/
jobStarted() { jobStarted() {
return this.job.started; return !this.job.started === false;
}, },
}, },
watch: { watch: {
......
...@@ -31,6 +31,7 @@ describe('Job details header', () => { ...@@ -31,6 +31,7 @@ describe('Job details header', () => {
email: 'foo@bar.com', email: 'foo@bar.com',
avatar_url: 'link', avatar_url: 'link',
}, },
started: '2018-01-08T09:48:27.319Z',
new_issue_path: 'path', new_issue_path: 'path',
}, },
isLoading: false, isLoading: false,
...@@ -43,15 +44,32 @@ describe('Job details header', () => { ...@@ -43,15 +44,32 @@ describe('Job details header', () => {
vm.$destroy(); vm.$destroy();
}); });
it('should render provided job information', () => { describe('triggered job', () => {
expect( beforeEach(() => {
vm.$el.querySelector('.header-main-content').textContent.replace(/\s+/g, ' ').trim(), vm = mountComponent(HeaderComponent, props);
).toEqual('failed Job #123 triggered 3 weeks ago by Foo'); });
it('should render provided job information', () => {
expect(
vm.$el.querySelector('.header-main-content').textContent.replace(/\s+/g, ' ').trim(),
).toEqual('failed Job #123 triggered 3 weeks ago by Foo');
});
it('should render new issue link', () => {
expect(
vm.$el.querySelector('.js-new-issue').getAttribute('href'),
).toEqual(props.job.new_issue_path);
});
}); });
it('should render new issue link', () => { describe('created job', () => {
expect( it('should render created key', () => {
vm.$el.querySelector('.js-new-issue').getAttribute('href'), props.job.started = false;
).toEqual(props.job.new_issue_path); vm = mountComponent(HeaderComponent, props);
expect(
vm.$el.querySelector('.header-main-content').textContent.replace(/\s+/g, ' ').trim(),
).toEqual('failed Job #123 created 3 weeks ago by Foo');
});
}); });
}); });
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment