BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
da972617
Commit
da972617
authored
Nov 22, 2016
by
Lin Jen-Shin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Move has_trace? to CommitStatus than GenericCommitStatus
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7617#note_18762721
parent
a2fb6361
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
7 deletions
+7
-7
commit_status.rb
app/models/commit_status.rb
+7
-3
generic_commit_status.rb
app/models/generic_commit_status.rb
+0
-4
No files found.
app/models/commit_status.rb
View file @
da972617
...
...
@@ -135,15 +135,19 @@ class CommitStatus < ActiveRecord::Base
allow_failure?
&&
(
failed?
||
canceled?
)
end
def
duration
calculate_duration
end
def
playable?
false
end
def
duration
calculate_duration
def
stuck?
false
end
def
stuck
?
def
has_trace
?
false
end
end
app/models/generic_commit_status.rb
View file @
da972617
...
...
@@ -12,8 +12,4 @@ class GenericCommitStatus < CommitStatus
def
tags
[
:external
]
end
def
has_trace?
false
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment