BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
d976941a
Commit
d976941a
authored
Oct 09, 2017
by
Robert Speicher
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'group-sort-dropdown-blank' into 'master'
Fixed default group sort option Closes #38808 See merge request gitlab-org/gitlab-ce!14728
parents
5d865bcc
2409acfa
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
12 additions
and
1 deletion
+12
-1
groups_controller.rb
app/controllers/dashboard/groups_controller.rb
+1
-1
group-sort-dropdown-blank.yml
changelogs/unreleased/group-sort-dropdown-blank.yml
+5
-0
group_spec.rb
spec/features/dashboard/group_spec.rb
+6
-0
No files found.
app/controllers/dashboard/groups_controller.rb
View file @
d976941a
class
Dashboard
::
GroupsController
<
Dashboard
::
ApplicationController
def
index
@sort
=
params
[
:sort
]
||
'
i
d_desc'
@sort
=
params
[
:sort
]
||
'
create
d_desc'
@groups
=
if
params
[
:parent_id
]
&&
Group
.
supports_nested_groups?
...
...
changelogs/unreleased/group-sort-dropdown-blank.yml
0 → 100644
View file @
d976941a
---
title
:
Fixed group sort dropdown defaulting to empty
merge_request
:
author
:
type
:
fixed
spec/features/dashboard/group_spec.rb
View file @
d976941a
...
...
@@ -5,6 +5,12 @@ RSpec.describe 'Dashboard Group' do
sign_in
(
create
(
:user
))
end
it
'defaults sort dropdown to last created'
do
visit
dashboard_groups_path
expect
(
page
).
to
have_button
(
'Last created'
)
end
it
'creates new group'
,
:js
do
visit
dashboard_groups_path
find
(
'.btn-new'
).
trigger
(
'click'
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment