BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
d7c50b4a
Commit
d7c50b4a
authored
Nov 03, 2014
by
Dmitriy Zaporozhets
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'api-events-username' into 'master'
Expose author username in project events API Fixes gitlab/gitlabhq#1476 See merge request !1236
parents
fe610ff5
9b251bd1
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
12 additions
and
0 deletions
+12
-0
CHANGELOG
CHANGELOG
+2
-0
projects.md
doc/api/projects.md
+3
-0
entities.rb
lib/api/entities.rb
+6
-0
projects_spec.rb
spec/requests/api/projects_spec.rb
+1
-0
No files found.
CHANGELOG
View file @
d7c50b4a
...
...
@@ -6,6 +6,8 @@ v 7.5.0
- Add Atlassian Bamboo CI service (Drew Blessing)
- Mentioned @user will receive email even if he is not participating in issue or commit
- Tie up loose ends with annotated tags: API & UI (Sean Edge)
- Return valid json for deleting branch via API (sponsored by O'Reilly Media)
- Expose username in project events API (sponsored by O'Reilly Media)
v 7.4.2
- Fix internal snippet exposing for unauthenticated users
...
...
doc/api/projects.md
View file @
d7c50b4a
...
...
@@ -186,6 +186,7 @@ Parameters:
"target_id"
:
830
,
"target_type"
:
"Issue"
,
"author_id"
:
1
,
"author_username"
:
"john"
,
"data"
:
null
,
"target_title"
:
"Public project search field"
},
...
...
@@ -196,6 +197,7 @@ Parameters:
"target_id"
:
null
,
"target_type"
:
null
,
"author_id"
:
1
,
"author_username"
:
"john"
,
"data"
:
{
"before"
:
"50d4420237a9de7be1304607147aec22e4a14af7"
,
"after"
:
"c5feabde2d8cd023215af4d2ceeb7a64839fc428"
,
...
...
@@ -231,6 +233,7 @@ Parameters:
"target_id"
:
840
,
"target_type"
:
"Issue"
,
"author_id"
:
1
,
"author_username"
:
"john"
,
"data"
:
null
,
"target_title"
:
"Finish & merge Code search PR"
}
...
...
lib/api/entities.rb
View file @
d7c50b4a
...
...
@@ -183,6 +183,12 @@ module API
expose
:target_id
,
:target_type
,
:author_id
expose
:data
,
:target_title
expose
:created_at
expose
:author_username
do
|
event
,
options
|
if
event
.
author
event
.
author
.
username
end
end
end
class
Namespace
<
Grape
::
Entity
...
...
spec/requests/api/projects_spec.rb
View file @
d7c50b4a
...
...
@@ -339,6 +339,7 @@ describe API::API, api: true do
json_event
[
'action_name'
].
should
==
'joined'
json_event
[
'project_id'
].
to_i
.
should
==
project
.
id
json_event
[
'author_username'
].
should
==
user
.
username
end
it
"should return a 404 error if not found"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment