Fix award-emojis alert flash message

This adds a new feature to `Flash` that allows to pin it after a specified selector. This removes a fixed position from such award-emoji alert, and makes it responsive by design of selector that this alert is pinned to. Closes #3996

Fix award-emojis alert flash message
d1211e0a · Grzegorz Bizon · 2029be03 · d1211e0a · d1211e0a · d1211e0a
Commit d1211e0a authored Dec 11, 2015 by Grzegorz Bizon
Showing with 3 additions and 13 deletions

flash.js.coffee app/assets/javascripts/flash.js.coffee +2 -2

notes.js.coffee app/assets/javascripts/notes.js.coffee +1 -1

flash.scss app/assets/stylesheets/framework/flash.scss +0 -10

No files found.
--- a/app/assets/javascripts/flash.js.coffee
+++ b/app/assets/javascripts/flash.js.coffee
@@ -12,5 +12,5 @@ class @Flash
    @flash.click -> $(@).fadeOut()
    @flash.show()

-  pin: ->
-    @flash.addClass('flash-pinned flash-raised')
+  pinTo: (selector) ->
+    @flash.detach().appendTo(selector)
--- a/app/assets/javascripts/notes.js.coffee
+++ b/app/assets/javascripts/notes.js.coffee
@@ -114,7 +114,7 @@ class @Notes
    unless note.valid
      if note.award
        flash = new Flash('You have already used this award emoji!', 'alert')
-        flash.pin()
+        flash.pinTo('.header-content')
      return

    # render note if it not present in loaded list

--- a/app/assets/stylesheets/framework/flash.scss
+++ b/app/assets/stylesheets/framework/flash.scss
@@ -15,13 +15,3 @@
    @extend .alert-danger;
  }
 }
-
-.flash-pinned {
-  position: fixed;
-  top: 80px;
-  width: 80%;
-}
-
-.flash-raised {
-  z-index: 1000;
-}