Merge branch '23036-replace-all-spinach-tests-with-rspec-feature-tests' into 'master'

changelogs/unreleased/23036-replace-all-spinach-tests-with-rspec-feature-tests.yml

+---
+title: Replace 'starred_projects.feature' spinach test with an rspec analog
+merge_request: 11752
+author: blackst0ne

features/dashboard/starred_projects.feature

-@dashboard
-Feature: Dashboard Starred Projects
-  Background:
-    Given I sign in as a user
-    And public project "Community"
-    And I starred project "Community"
-    And I own project "Shop"
-    And I visit dashboard starred projects page
-
-  Scenario: I should see projects list
-    Then I should see project "Community"
-    And I should not see project "Shop"

spec/features/dashboard/projects_spec.rb

@@ -3,10 +3,11 @@ require 'spec_helper'
 RSpec.describe 'Dashboard Projects', feature: true do
   let(:user) { create(:user) }
   let(:project) { create(:project, name: "awesome stuff") }
+  let(:project2) { create(:project, :public, name: 'Community project') }
 
   before do
     project.team << [user, :developer]
-    login_as user
+    login_as(user)
   end
 
   it 'shows the project the user in a member of in the list' do
@@ -14,6 +15,17 @@ RSpec.describe 'Dashboard Projects', feature: true do
     expect(page).to have_content('awesome stuff')
   end
 
+  context 'when on Starred projects tab' do
+    it 'shows only starred projects' do
+      user.toggle_star(project2)
+
+      visit(starred_dashboard_projects_path)
+
+      expect(page).not_to have_content(project.name)
+      expect(page).to have_content(project2.name)
+    end
+  end
+
   describe "with a pipeline", redis: true do
     let!(:pipeline) {  create(:ci_pipeline, project: project, sha: project.commit.sha) }