Eliminate unnecessary queries that add ~500 ms of load time for a large issue

Looking at the SQL log, we see useless queries such as: ``` D, [2017-03-22T03:25:00.726710 #2629] DEBUG -- : (235.9ms) SELECT MAX("project_authorizations"."access_level") AS maximum_access_level, "project_authorizations"."user_id" AS project_authorizations_user_id FROM "project_authorizations" WHERE "project_authorizations"."project_id" = 13083 AND 1=0 GROUP BY "project_authorizations"."user_id" [["project_id", 13083]] ```

Eliminate unnecessary queries that add ~500 ms of load time for a large issue
ced1bbab · Stan Hu · bcb0a554 · ced1bbab
Commit ced1bbab authored Mar 30, 2017 by Stan Hu
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

project_team.rb app/models/project_team.rb +3 -0

No files found.
--- a/app/models/project_team.rb
+++ b/app/models/project_team.rb
@@ -169,6 +169,9 @@ class ProjectTeam

    # Lookup only the IDs we need
    user_ids = user_ids - access.keys
+
+    return access if user_ids.empty?
+
    users_access = project.project_authorizations.
      where(user: user_ids).
      group(:user_id).