Just use find_by! and we're rescuing ActiveRecord::RecordNotFound

Feedback: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13125645

Just use find_by! and we're rescuing ActiveRecord::RecordNotFound
cc91f09a · Lin Jen-Shin · 6830e282 · cc91f09a
Commit cc91f09a authored Jul 18, 2016 by Lin Jen-Shin
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 6 deletions

builds.rb lib/api/builds.rb +2 -6

No files found.
--- a/lib/api/builds.rb
+++ b/lib/api/builds.rb
@@ -84,13 +84,9 @@ module API
      get ':id/builds/artifacts/:ref_name/download',
        requirements: { ref_name: /.+/ } do
        builds = user_project.latest_success_builds_for(params[:ref_name])
-        latest_build = builds.where(name: params[:job]).first
+        latest_build = builds.find_by!(name: params[:job])

-        if latest_build
-          present_artifact!(latest_build.artifacts_file)
-        else
-          not_found!
-        end
+        present_artifact!(latest_build.artifacts_file)
      end

      # Get a trace of a specific build of a project