Fix `CreateDeploymentService` spec.

1. The spec tests that if: - The merge request is merged - The target branch is deployed to production - The `first_deployed_to_production_at` metric is `nil` (for some reason) - The target branch is deployed to production again - The `first_deployed_to_production_at` metric stays as `nil` (and is not overwritten). 2. Failure only on MySQL due to some datetime weirdness.

Fix `CreateDeploymentService` spec.
cc3adcd4 · Timothy Andrew · ef8badb6 · cc3adcd4
Commit cc3adcd4 authored Sep 21, 2016 by Timothy Andrew
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

create_deployment_service_spec.rb spec/services/create_deployment_service_spec.rb +4 -1

No files found.
--- a/spec/services/create_deployment_service_spec.rb
+++ b/spec/services/create_deployment_service_spec.rb
@@ -229,8 +229,11 @@ describe CreateDeploymentService, services: true do
        context "if the 'first_deployed_to_production_at' time is not already set" do
          it "does not overwrite the older 'first_deployed_to_production_at' time" do
            # Previous deploy
-            time = Time.now
+            time = 5.minutes.from_now
            Timecop.freeze(time) { service.execute }
+
+            expect(merge_request.reload.metrics.merged_at).to be < merge_request.reload.metrics.first_deployed_to_production_at
+
            merge_request.reload.metrics.update(first_deployed_to_production_at: nil)

            expect(merge_request.reload.metrics.first_deployed_to_production_at).to be_nil