BigW Consortium Gitlab
Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
G
gitlab-ce
Project
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
Forest Godfrey
gitlab-ce
Commits
c85c146a
Commit
c85c146a
authored
Oct 23, 2016
by
Gauvain Pocentek
Committed by
Sean McGivern
Nov 01, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add support for token attr in project hooks API
The UI allows to define a token to validate payload on the target URL, this patch adds the feature to the API.
parent
266fcfb1
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
12 additions
and
3 deletions
+12
-3
CHANGELOG.md
CHANGELOG.md
+1
-0
projects.md
doc/api/projects.md
+2
-0
entities.rb
lib/api/entities.rb
+1
-1
project_hooks.rb
lib/api/project_hooks.rb
+4
-2
project_hooks_spec.rb
spec/requests/api/project_hooks_spec.rb
+4
-0
No files found.
CHANGELOG.md
View file @
c85c146a
...
...
@@ -6,6 +6,7 @@ Please view this file on the master branch, on stable branches it's out of date.
-
Adds user project membership expired event to clarify why user was removed (Callum Dryden)
-
Trim leading and trailing whitespace on project_path (Linus Thiel)
-
Prevent award emoji via notes for issues/MRs authored by user (barthc)
-
Adds support for the
`token`
attribute in project hooks API (Gauvain Pocentek)
-
Adds an optional path parameter to the Commits API to filter commits by path (Luis HGO)
-
Fix extra space on Build sidebar on Firefox !7060
-
Fix mobile layout issues in admin user overview page !7087
...
...
doc/api/projects.md
View file @
c85c146a
...
...
@@ -1139,6 +1139,7 @@ Parameters:
|
`pipeline_events`
| boolean | no | Trigger hook on pipeline events |
|
`wiki_events`
| boolean | no | Trigger hook on wiki events |
|
`enable_ssl_verification`
| boolean | no | Do SSL verification when triggering the hook |
|
`token`
| string | no | Secret token to validate received payloads |
### Edit project hook
...
...
@@ -1164,6 +1165,7 @@ Parameters:
|
`pipeline_events`
| boolean | no | Trigger hook on pipeline events |
|
`wiki_events`
| boolean | no | Trigger hook on wiki events |
|
`enable_ssl_verification`
| boolean | no | Do SSL verification when triggering the hook |
|
`token`
| string | no | Secret token to validate received payloads |
### Delete project hook
...
...
lib/api/entities.rb
View file @
c85c146a
...
...
@@ -50,7 +50,7 @@ module API
expose
:project_id
,
:push_events
expose
:issues_events
,
:merge_requests_events
,
:tag_push_events
expose
:note_events
,
:build_events
,
:pipeline_events
,
:wiki_page_events
expose
:enable_ssl_verification
expose
:enable_ssl_verification
,
:token
end
class
BasicProjectDetails
<
Grape
::
Entity
...
...
lib/api/project_hooks.rb
View file @
c85c146a
...
...
@@ -47,7 +47,8 @@ module API
:build_events
,
:pipeline_events
,
:wiki_page_events
,
:enable_ssl_verification
:enable_ssl_verification
,
:token
]
@hook
=
user_project
.
hooks
.
new
(
attrs
)
...
...
@@ -82,7 +83,8 @@ module API
:build_events
,
:pipeline_events
,
:wiki_page_events
,
:enable_ssl_verification
:enable_ssl_verification
,
:token
]
if
@hook
.
update_attributes
attrs
...
...
spec/requests/api/project_hooks_spec.rb
View file @
c85c146a
...
...
@@ -36,6 +36,7 @@ describe API::API, 'ProjectHooks', api: true do
expect
(
json_response
.
first
[
'pipeline_events'
]).
to
eq
(
true
)
expect
(
json_response
.
first
[
'wiki_page_events'
]).
to
eq
(
true
)
expect
(
json_response
.
first
[
'enable_ssl_verification'
]).
to
eq
(
true
)
expect
(
json_response
.
first
[
'token'
]).
to
eq
(
'S3cr3t'
)
end
end
...
...
@@ -62,6 +63,7 @@ describe API::API, 'ProjectHooks', api: true do
expect
(
json_response
[
'pipeline_events'
]).
to
eq
(
hook
.
pipeline_events
)
expect
(
json_response
[
'wiki_page_events'
]).
to
eq
(
hook
.
wiki_page_events
)
expect
(
json_response
[
'enable_ssl_verification'
]).
to
eq
(
hook
.
enable_ssl_verification
)
expect
(
json_response
[
'token'
]).
to
eq
(
hook
.
token
)
end
it
"returns a 404 error if hook id is not available"
do
...
...
@@ -99,6 +101,7 @@ describe API::API, 'ProjectHooks', api: true do
expect
(
json_response
[
'pipeline_events'
]).
to
eq
(
false
)
expect
(
json_response
[
'wiki_page_events'
]).
to
eq
(
false
)
expect
(
json_response
[
'enable_ssl_verification'
]).
to
eq
(
true
)
expect
(
json_response
[
'token'
]).
to
eq
(
'S3cr3t'
)
end
it
"returns a 400 error if url not given"
do
...
...
@@ -127,6 +130,7 @@ describe API::API, 'ProjectHooks', api: true do
expect
(
json_response
[
'pipeline_events'
]).
to
eq
(
hook
.
pipeline_events
)
expect
(
json_response
[
'wiki_page_events'
]).
to
eq
(
hook
.
wiki_page_events
)
expect
(
json_response
[
'enable_ssl_verification'
]).
to
eq
(
hook
.
enable_ssl_verification
)
expect
(
json_response
[
'token'
]).
to
eq
(
hook
.
token
)
end
it
"returns 404 error if hook id not found"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment