Validate user id for users select autcomplete

Single user autcomplete should be used only for existing users with digital ID provided. Now js code puts any input into generating user URL which can lead to 500 error because routing like this does not exists: GET "/autocomplete/users/whatever@example.com.json". Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

Validate user id for users select autcomplete
c736ffdf · Dmitriy Zaporozhets · 48d223d7 · c736ffdf
Unverified Commit c736ffdf authored Oct 14, 2016 by Dmitriy Zaporozhets
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

users_select.js app/assets/javascripts/users_select.js +4 -0

No files found.
--- a/app/assets/javascripts/users_select.js
+++ b/app/assets/javascripts/users_select.js
@@ -325,6 +325,10 @@
    };

    UsersSelect.prototype.user = function(user_id, callback) {
+      if(!/^\d+$/.test(user_id)) {
+        return false;
+      }
+
      var url;
      url = this.buildUrl(this.userPath);
      url = url.replace(':id', user_id);