Use #sub instead of #gsub!. #3945

* This is because is not a good idea to modify the original lines * Also I run into this issue https://gitlab.com/gitlab-org/gitlab_git/issues/14 which is returning Diff Lines with the same @new_pos value.

Use #sub instead of #gsub!. #3945
c179b48c · Rubén Dávila · 1161cf2e · c179b48c
Commit c179b48c authored Jan 13, 2016 by Rubén Dávila
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

highlight.rb lib/gitlab/diff/highlight.rb +1 -1

No files found.
--- a/lib/gitlab/diff/highlight.rb
+++ b/lib/gitlab/diff/highlight.rb
@@ -73,7 +73,7 @@ module Gitlab

          # Only update text if line is found. This will prevent
          # issues with submodules given the line only exists in diff content.
-          line.text = highlighted_line.gsub!(/\A\s/, line_prefix).html_safe if highlighted_line
+          line.text = highlighted_line.sub(/\A\s/, line_prefix).html_safe if highlighted_line
        end

        @lines